Skip to content

fix #2416 bookie format redundant clean ledgerDirs and indexDirs#2417

Merged
sijie merged 4 commits into
apache:masterfrom
NeatGuyCoding:fix_issue_2416
Oct 8, 2020
Merged

fix #2416 bookie format redundant clean ledgerDirs and indexDirs#2417
sijie merged 4 commits into
apache:masterfrom
NeatGuyCoding:fix_issue_2416

Conversation

@NeatGuyCoding

Copy link
Copy Markdown
Contributor

bookie format redundant clean ledgerDirs and indexDirs

@eolivelli

Copy link
Copy Markdown
Contributor

can you please rebase to current master ?

lifepuzzlefun and others added 3 commits September 26, 2020 08:46
the web site rendering error in section reference/cli/ updateBookieInLedger Options
@NeatGuyCoding

Copy link
Copy Markdown
Contributor Author

can you please rebase to current master ?

rebased

@eolivelli eolivelli requested a review from rdhabalia October 5, 2020 14:09

@eolivelli eolivelli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eolivelli

Copy link
Copy Markdown
Contributor

as pointed out by @fpj
tests are failing but github is reporting "all checks have passed"
https://github.com/apache/bookkeeper/pull/2417/checks?check_run_id=1174551641

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants