Skip to content

Fix async log appender not print error log when bookie starting expectionally #4475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StevenLuMT merged 2 commits into from
Feb 17, 2025
Merged

Fix async log appender not print error log when bookie starting expectionally #4475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79585ff
Shutdown log before bookie exit to flush async log
AnonHxy Jul 27, 2024
8ca7f88
remove log4j dependency
AnonHxy Jul 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bookkeeper-common/src/main/java/org/apache/bookkeeper/common/component/ComponentStarter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ public static CompletableFuture<Void> startComponent(LifecycleComponent componen
component.setExceptionHandler((t, e) -> {
log.error("Triggered exceptionHandler of Component: {} because of Exception in Thread: {}",
component.getName(), t, e);
System.err.println(e.getMessage());
// start the shutdown hook when an uncaught exception happen in the lifecycle component.
shutdownHookThread.start();
});
Expand Down
3 changes: 3 additions & 0 deletions bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/AutoRecoveryMain.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,7 @@ static int doMain(String[] args) {
server = buildAutoRecoveryServer(new BookieConfiguration(conf));
} catch (Exception e) {
LOG.error("Failed to build AutoRecovery Server", e);
System.err.println(e.getMessage());
return ExitCode.SERVER_EXCEPTION;
}

Expand All @@ -349,8 +350,10 @@ static int doMain(String[] args) {
Thread.currentThread().interrupt();
// the server is interrupted
LOG.info("AutoRecovery server is interrupted. Exiting ...");
System.err.println(ie.getMessage());
} catch (ExecutionException ee) {
LOG.error("Error in bookie shutdown", ee.getCause());
System.err.println(ee.getMessage());
return ExitCode.SERVER_EXCEPTION;
}
return ExitCode.OK;
Expand Down
3 changes: 3 additions & 0 deletions bookkeeper-server/src/main/java/org/apache/bookkeeper/server/Main.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,7 @@ static int doMain(String[] args) {
server = buildBookieServer(new BookieConfiguration(conf));
} catch (Exception e) {
log.error("Failed to build bookie server", e);
System.err.println(e.getMessage());
return ExitCode.SERVER_EXCEPTION;
}

Expand All @@ -232,8 +233,10 @@ static int doMain(String[] args) {
Thread.currentThread().interrupt();
// the server is interrupted
log.info("Bookie server is interrupted. Exiting ...");
System.err.println(ie.getMessage());
} catch (ExecutionException ee) {
log.error("Error in bookie shutdown", ee.getCause());
System.err.println(ee.getMessage());
return ExitCode.SERVER_EXCEPTION;
}
return ExitCode.OK;
Expand Down
3 changes: 3 additions & 0 deletions stream/server/src/main/java/org/apache/bookkeeper/stream/server/StorageServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,7 @@ static int doMain(String[] args) {
grpcUseHostname);
} catch (Exception e) {
log.error("Invalid storage configuration", e);
System.err.println(e.getMessage());
return ExitCode.INVALID_CONF.code();
}

Expand All @@ -181,8 +182,10 @@ static int doMain(String[] args) {
// the server is interrupted.
Thread.currentThread().interrupt();
log.info("Storage server is interrupted. Exiting ...");
System.err.println(e.getMessage());
} catch (ExecutionException e) {
log.info("Storage server is exiting ...");
System.err.println(e.getMessage());
}
return ExitCode.OK.code();
}
Expand Down