Fix a NPE bug after refactor recycler of BookieClient

[TakaHiR07]

Motivation

After refactor recycler of bookieClient and test for a few days in cluster, there is a NPE bug.

In CompletionValue#timeout(), it would do errorOut() and then register latency in timeoutOpLogger. But errorOut() would trigger writeComplete() and then recycle the completionValue object. So the timeoutOpLogger is also recycle and throw NPE.

Changes

change the execute order: register latency first and then do errorOut().

Alternative fix is like:

void timeout() {
        OpStatsLogger logger = timeoutOpLogger;
        errorOut(BKException.Code.TimeoutException);
        logger.registerSuccessfulEvent(latency(),
                TimeUnit.NANOSECONDS);
}

But I think it is unnecessary to record the errorOut() time in prometheus, because this time cost has no influence of this timeout metric.

[Copilot]

Pull Request Overview

This PR fixes a Null Pointer Exception in CompletionValue.timeout by reordering the execution sequence.

• The latency registration is now executed before calling errorOut.
• The change prevents the timeoutOpLogger from being recycled before its usage.

Comments suppressed due to low confidence (1)

bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/CompletionValue.java:92

• The reordering of the latency registration before errorOut should resolve the NPE issue by ensuring that timeoutOpLogger is not recycled before its use. Please verify that this change does not introduce any side effects in the error handling logic.

errorOut(BKException.Code.TimeoutException);

[StevenLuMT]

Good jobs

[StevenLuMT]

1. This is based on Fix Memory Leak In Netty Recycler of Bookie Client #4609, so I also added Fix Memory Leak In Netty Recycler of Bookie Client #4609 to release/4.17.2 , cc @zymap

2. kept consistent without introducing new features Fix Memory Leak In Netty Recycler of Bookie Client #4609 to release/4.16.7