[fix] Fix issue where options for sanity test command are ignored - #4691
Merged
Conversation
hangc0276
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
bookiesanitysubcommand of Bookie Shell enables users to specify the number of entries and the timeout in seconds as command line options.However, in practice these options seem to be ignored and the default values (entries: 10, timeout: 1) always used.
Changes
After creating an instance of the
SanityTestCommand.SanityFlagsclass in theBookieShellclass, the option values specified on the command line should be passed to it, but this was not actually done.