Fix LedgerHandle batchReadUnconfirmedAsync: use slog log instead of LOG#4782
Merged
Conversation
The batchReadUnconfirmedAsync method added in apache#4739 calls LOG.error(...), but LedgerHandle was migrated to slog and only has a lowercase `log` field. Master fails to compile. Convert the call to the slog builder style used elsewhere in the file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The new `batchReadUnconfirmedAsync` method added in #4739 calls `LOG.error(...)`, but `LedgerHandle` was already migrated to slog and only has a lowercase `log` field. As a result, master fails to compile (`cannot find symbol: variable LOG`), which also blocks every open PR.
This change converts the call to the slog builder style used elsewhere in the same file.
Test plan