perf: optimize enforcement hot paths - #422
Open
H-Chris233 wants to merge 2 commits into
Open
Conversation
Compute p_eft index once in src/enforcer.rs and reuse it instead of calling .position repeatedly, reducing repeated iteration. In src/model/function_map.rs add static compiled regexes (MAT_COLON, MAT_BRACE) and replace on-the-fly Regex::new calls with these statics, adjust replacements/escaping accordingly. Small performance-focused refactor with no behavior changes.
Add no-op benchmark functions gated by #[cfg(not(feature = "cached"))] so Criterion groups compile when the "cached" feature is disabled. Simplify event handler insertion by using or_default(), remove unnecessary references when calling private_enforce/private_enforce_with_context, and add early-return cache checks in enforce/enforce_with_context behind #[cfg(not(feature = "logging"))] to avoid work when a cached result exists. These changes clean up code, fix feature-flagged build issues, and optimize the cache fast path.
Benchmark Results |
Contributor
Author
Local benchmark verificationEnvironment: local Windows machine (noisy, ±20–30% run-to-run), 3 alternating
Findings:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR includes two performance optimizations for the enforcement hot path:
p_efttoken index to avoid repeated lookups for each policy.CachedEnforcercache hits to skip redundant argument conversion.Performance
Improves cached enforcement by approximately 36%–45% on cache hits.
Verification
Tests, Clippy checks, and runtime combinations pass with both default and cached configurations.