-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CASSANDRA-17750: Add docs for dependency management changes #170
Open
aratno
wants to merge
13
commits into
apache:trunk
Choose a base branch
from
aratno:CASSANDRA-17750
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
97d1340
Add docs for dependency management changes in CASSANDRA-17750
aratno dd7af1c
4.1 -> 4.2
aratno 1b81c58
Expand documentation
aratno 23f2f82
Rm outdated lib steps
aratno 0411c2c
Separate pre-4.2 and post-4.2 documentation per feedback
aratno ed4d65a
Update intro
aratno 62c7546
Updates based on Claude Warren's feedback
aratno 1591f8e
Fix typo
aratno c1211af
Apache -> ASF
aratno 1889d09
4.2 -> 5.0
aratno ed2c1a5
Clarify release process
aratno 8a6bd37
Clarify lib/ and resolver-dist-lib, per PR feedback
aratno fd4d6f7
Fix link
aratno File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -39,6 +39,11 @@ can be included in: | |
|
||
The `ant write-poms` target produces valid POM files in the `build/` directory. | ||
|
||
Dependencies added to the `lib/` directory are built into the release artifacts | ||
by the `ant artifacts` target (see target `resolver-dist-lib`). Libraries | ||
distributed this way must meet the | ||
[https://www.apache.org/legal/resolved.html]ASF distribution policy. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. link is not working, There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oopsies - fixed |
||
|
||
=== Dependency management before Cassandra 5.0 | ||
|
||
To update dependencies, update the parent and child POM definitions in | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The POM FIle Types section does not make sense where it is now. As it is at the same level as the 4.2 and pre-4.2 sections it would appear to apply to both, however, it mentions files that are only in the pre-4.2 code. I think that a section for the POMs found in each section would be cleaner and easier to understand.