[CELEBORN-2046] Specify extractionDir of AsyncProfilerLoader with celeborn.worker.jvmProfiler.localDir #3345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eborn.worker.storage.workingDir
SteNicholas
force-pushed
the
CELEBORN-2046
branch
from
379b053 to
58c646a
Compare
SteNicholas
commented
Jun 24, 2025
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/profiler/JVMProfiler.scala
Outdated
Show resolved
Hide resolved
turboFei
reviewed
Jun 25, 2025
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/profiler/JVMProfiler.scala
Outdated
Show resolved
Hide resolved
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/profiler/JVMProfiler.scala
Outdated
Show resolved
Hide resolved
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/profiler/JVMProfiler.scala
Outdated
Show resolved
Hide resolved
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/profiler/JVMProfiler.scala
Outdated
Show resolved
Hide resolved
…eborn.worker.storage.workingDir
turboFei
reviewed
Jun 25, 2025
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/profiler/JVMProfiler.scala
Outdated
Show resolved
Hide resolved
turboFei
approved these changes
Jun 25, 2025
|
also update the PR title |
SteNicholas
changed the title
…eborn.worker.jvmProfiler.localDir
SteNicholas
force-pushed
the
CELEBORN-2046
branch
from
381cc32 to
b4f13e9
Compare
|
@turboFei, thanks for reminder. The title of pull request and the commit message have updated. |
|
thanks, merging to main and branch-0.6(0.6.0) |
turboFei
pushed a commit
that referenced
this pull request
Jun 25, 2025
…eborn.worker.jvmProfiler.localDir ### What changes were proposed in this pull request? Specify `extractionDir` of `AsyncProfilerLoader` with `celeborn.worker.jvmProfiler.localDir`. ### Why are the changes needed? `AsyncProfilerLoader` uses `user.home` directory to store the extracted libraries by default . When `user.home` directory is not initialized, it will cause `AsyncProfilerLoader#load` to fail. `extractionDir` of `AsyncProfilerLoader` could be specified with `celeborn.worker.jvmProfiler.localDir` to avoid failure of loading. Backport apache/spark#51229. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manual test. Closes #3345 from SteNicholas/CELEBORN-2046. Lead-authored-by: SteNicholas <[email protected]> Co-authored-by: 子懿 <[email protected]> Signed-off-by: Wang, Fei <[email protected]> (cherry picked from commit 3ee3a26) Signed-off-by: Wang, Fei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Specify
extractionDirofAsyncProfilerLoaderwithceleborn.worker.jvmProfiler.localDir.Why are the changes needed?
AsyncProfilerLoaderusesuser.homedirectory to store the extracted libraries by default . Whenuser.homedirectory is not initialized, it will causeAsyncProfilerLoader#loadto fail.extractionDirofAsyncProfilerLoadercould be specified withceleborn.worker.jvmProfiler.localDirto avoid failure of loading.Backport apache/spark#51229.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual test.