Fix the issue of duplicate counting of num_executed in gp_toolkit.gp_resgroup_status#1646
Merged
tuhaihe merged 1 commit intoapache:mainfrom Apr 1, 2026
Merged
Fix the issue of duplicate counting of num_executed in gp_toolkit.gp_resgroup_status#1646tuhaihe merged 1 commit intoapache:mainfrom
tuhaihe merged 1 commit intoapache:mainfrom
Conversation
my-ship-it
approved these changes
Mar 30, 2026
Contributor
my-ship-it
left a comment
my-ship-it
left a comment
There was a problem hiding this comment.
LGTM! Nice catch on this inherited GPDB defect. 👍
…resgroup_status This is a defect of the original GPDB. When enabling resource group management and the transaction switches from "Assign" to "Bypass" state, the "num_executed" counter is repeatedly counted.
my-ship-it
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix the issue of duplicate counting of num_executed in gp_toolkit.gp_resgroup_status
This is a defect of the original GPDB.
When enabling resource group management and the transaction switches from "Assigned" to "Bypass" state, the "num_executed" counter is repeatedly counted.
Reproducing test cases:
Enable resource group: set gp_resource_manager to "group".
Log in with the default superuser.
Execute gp_toolkit.gp_resgroup_status twice.
The test case has been added to:
src/test/isolation2/sql/resgroup/resgroup_bypass.sql
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions