Skip to content

Revert "Fix COPY TO returning 0 rows during concurrent reorganize"#1657

Merged
yjhjstz merged 1 commit intoapache:mainfrom
yjhjstz:revert_f979799
Apr 1, 2026
Merged

Revert "Fix COPY TO returning 0 rows during concurrent reorganize"#1657
yjhjstz merged 1 commit intoapache:mainfrom
yjhjstz:revert_f979799

Conversation

@yjhjstz
Copy link
Copy Markdown
Member

@yjhjstz yjhjstz commented Apr 1, 2026

This reverts commit f979799.

Thread 1 (Thread 0xffff81ecf000 (LWP 143287)):
#0  0x0000ffff81f37238 in raise () from /lib64/libc.so.6
#1  0x0000ffff81f388b0 in abort () from /lib64/libc.so.6
#2  0x0000aaaaba8c3d74 in ExceptionalCondition (conditionName=0xaaaabb752550 "portal->portalSnapshot == GetActiveSnapshot()", errorType=0xaaaabb7521b8 "FailedAssertion", fileName=0xaaaabb752280 "pquery.c", lineNumber=1394) at assert.c:48
#3  0x0000aaaaba6d7ad4 in PortalRunUtility (portal=0xaaaad65e5a30, pstmt=0xaaaad63acac8, isTopLevel=true, setHoldSnapshot=false, dest=0xaaaad63ad008, qc=0xfffffacbb970) at pquery.c:1394
#4  0x0000aaaaba6d7df8 in PortalRunMulti (portal=0xaaaad65e5a30, isTopLevel=true, setHoldSnapshot=false, dest=0xaaaad63ad008, altdest=0xaaaad63ad008, qc=0xfffffacbb970) at pquery.c:1531
#5  0x0000aaaaba6d7108 in PortalRun (portal=0xaaaad65e5a30, count=9223372036854775807, isTopLevel=true, run_once=true, dest=0xaaaad63ad008, altdest=0xaaaad63ad008, qc=0xfffffacbb970) at pquery.c:999
#6  0x0000aaaaba6cc7ec in exec_mpp_query (query_string=0xaaaad63ac202 "COPY  y TO STDOUT (FORMAT CSV, QUOTE '''', DELIMITER '|')", serializedPlantree=0xaaaad63ac23c "(\265/\375 \341E\003", serializedPlantreelen=113, serializedQueryDispatchDesc=0x0, serializedQueryDispatchDesclen=0) at postgres.c:1423
#7  0x0000aaaaba6d44c8 in PostgresMain (argc=1, argv=0xfffffacbbd58, dbname=0xaaaad655be70 "regression", username=0xaaaad655be50 "gpadmin") at postgres.c:5889
#8  0x0000aaaaba5d2d10 in BackendRun (port=0xaaaad63cf600) at postmaster.c:5098
#9  0x0000aaaaba5d2570 in BackendStartup (port=0xaaaad63cf600) at postmaster.c:4802
#10 0x0000aaaaba5ccd6c in ServerLoop () at postmaster.c:2052
#11 0x0000aaaaba5cc45c in PostmasterMain (argc=7, argv=0xaaaad6368720) at postmaster.c:1677
#12 0x0000aaaaba43f3e4 in main (argc=7, argv=0xaaaad6368720) at main.c:269

What does this PR do?

Type of Change

  • Bug fix (non-breaking change)
  • New feature (non-breaking change)
  • Breaking change (fix or feature with breaking changes)
  • Documentation update

Breaking Changes

Test Plan

  • Unit tests added/updated
  • Integration tests added/updated
  • Passed make installcheck
  • Passed make -C src/test installcheck-cbdb-parallel

Impact

Performance:

User-facing changes:

Dependencies:

Checklist

Additional Context

CI Skip Instructions


Copy link
Copy Markdown
Contributor

@my-ship-it my-ship-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@yjhjstz yjhjstz requested review from gfphoenix78 and reshke April 1, 2026 13:09
Copy link
Copy Markdown
Contributor

@reshke reshke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Are we planning to actually fix COPY? If yes, will we pursue f979799 way further or we need to redesign fix entirely?

@yjhjstz yjhjstz merged commit 1e2fe33 into apache:main Apr 1, 2026
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants