Improve the SQL tab-completion feature for resource group#1669
Improve the SQL tab-completion feature for resource group#1669reshke merged 2 commits intoapache:mainfrom
Conversation
1. For the time being, we will not handle the tab-completion feature of resource queue because there is a trend for resource group to replace resource queue. 2. Correct the description of the gp_resource_manager parameter.
my-ship-it
left a comment
There was a problem hiding this comment.
LGTM
Clean, focused fix that addresses a real usability gap.
Only suggestion: confirm group-v2 is already a supported gp_resource_manager value.
leborchuk
left a comment
There was a problem hiding this comment.
Yes, here https://github.com/apache/cloudberry/blob/main/src/backend/cdb/cdbvars.c#L526 we check if gp_resource_manager could one of 3 supported items, not 2 as was in previous help string
Also here the set of resource group grama and options https://github.com/apache/cloudberry/blob/main/src/backend/parser/gram.y#L1752 - SQL syntax was correctly reflected in a tab completion and options are the same as in a gram.y
LGTM
Sorry to reply you later. |
What does this PR do?
Improve the SQL tab-completion feature for resource group
When manually typing the SQL for resource group management in the psql client, the auto-completion(tab-completion) function is not complete enough.
In particular, the auto-completion of the ALTER RESOURCE GROUP command is lacking.
For example, auto-completion cannot continue after "ALTER RESOURCE ".
Key points of modification:
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions