Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine/orchestration: fix missing vm powerstate update vm state #10407

Open
wants to merge 4 commits into
base: 4.20
Choose a base branch
from
Open

engine/orchestration: fix missing vm powerstate update vm state #10407

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c4657a9
engine/orchestration: fix missing vm powerstate update vm state
shwstppr Feb 17, 2025
aba797c
add unit tests
shwstppr Feb 18, 2025
bbca682
add license
shwstppr Feb 18, 2025
00a13ca
add lenient
shwstppr Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions engine/orchestration/src/main/java/com/cloud/vm/VirtualMachinePowerStateSyncImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,13 +83,13 @@
return;
}
Set<Long> vmIds = instancePowerStates.keySet();
Map<Long, VirtualMachine.PowerState> notUpdated = _instanceDao.updatePowerState(instancePowerStates, hostId,
updateTime);
Map<Long, VirtualMachine.PowerState> notUpdated =
_instanceDao.updatePowerState(instancePowerStates, hostId, updateTime);

Check warning on line 87 in engine/orchestration/src/main/java/com/cloud/vm/VirtualMachinePowerStateSyncImpl.java

View check run for this annotation

Codecov / codecov/patch

engine/orchestration/src/main/java/com/cloud/vm/VirtualMachinePowerStateSyncImpl.java#L86-L87 

Added lines #L86 - L87 were not covered by tests
if (notUpdated.size() > vmIds.size()) {
return;
}
for (Long vmId : vmIds) {
if (!notUpdated.isEmpty() && !notUpdated.containsKey(vmId)) {
if (!notUpdated.containsKey(vmId)) {
logger.debug("VM state report is updated. {}, {}, power state: {}",
() -> hostCache.get(hostId), () -> vmCache.get(vmId), () -> instancePowerStates.get(vmId));
_messageBus.publish(null, VirtualMachineManager.Topics.VM_POWER_STATE,
Expand Down
Loading