Add logs for storage pools reordering#10419
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.22 #10419 +/- ##
=========================================
Coverage 17.62% 17.62%
- Complexity 15668 15669 +1
=========================================
Files 5917 5917
Lines 531255 531253 -2
Branches 64951 64947 -4
=========================================
+ Hits 93639 93641 +2
+ Misses 427077 427075 -2
+ Partials 10539 10537 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DaanHoogland
left a comment
DaanHoogland
left a comment
There was a problem hiding this comment.
one general remark on these changes; I see only trace and debug logs, but if axtra logs are really needed I would expect at least hight level logging to be added (info and higher) were considerations made to do this? (DEBUG should not be on in production environments in principle, unless trouble shooting is going on)
|
Alright, I've just changed the level of logs on reordering methods, @DaanHoogland |
DaanHoogland
left a comment
DaanHoogland
left a comment
There was a problem hiding this comment.
makes mostly sense, just one info i'd like to question.
|
@blueorangutan package |
|
@julien-vaz a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12691 |
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
|
@julien-vaz could you fix the conflicts? |
Sure! |
julien-vaz
force-pushed
the
add-logs-storage-pool-reordering
branch
from
53c59bf to
04e69aa
Compare
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 13617 |
|
@blueorangutan test |
|
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-13481)
|
|
@sureshanaparti , do you think we need anymore testing on this? (/me not convinced) |
|
I've just built the packages locally, so I'm triggering the Blue Orangutan again. |
|
@blueorangutan package |
|
@julien-vaz a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
…ocator/AbstractStoragePoolAllocator.java Co-authored-by: dahn <daan.hoogland@gmail.com>
erik-bock-silva
force-pushed
the
add-logs-storage-pool-reordering
branch
from
b69581a to
de58344
Compare
|
Hello, @borisstoyanov and @rajujith The conflicts were solved, can we move forward with this PR? I think it is ready to be merged. |
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
@julien-vaz @erikbocks can you check the build errors. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16813 |
|
@sureshanaparti I runned the tests locally and no problem was found. I will trigger the build again. |
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17450 |
|
@blueorangutan test |
|
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-15857)
|
|
[SF] Trillian test result (tid-15860)
|
|
@sureshanaparti , I think this is ready for merge. Only logging and integration tests pass in the lab, GHA don’t all pass, but that seems like a more generic issue than this PR. What do you think? |
agree @DaanHoogland |
sureshanaparti
added
status:ready-for-merge
and removed
status:needs-testing
ready-for-testing
labels
github-project-automation
Bot
moved this from In Progress
to Done
in Apache CloudStack 4.22.1
Source Apache commits:\n- 161b417 Add logs for storage pools reordering (apache#10419)\n\nChange summary:\n- expand allocator logging around pool reordering, shuffle, disk provisioning, and search boundaries\n- route userconcentratedpod_random through the random reorder path\n\nFunctional impact:\n- improves observability when debugging storage allocator decisions\n- preserves random pool reordering behavior for legacy userconcentratedpod_random configurations\n\nConflict handling:\n- apache cherry-pick conflicted in reorderStoragePoolsBasedOnAlgorithm because local/main had drifted\n- resolved by keeping the apache condition and updated logging behavior\n\nVerification:\n- conflict markers removed and resolved allocator method inspected\n- mvn/mvnw not available in this workspace, so module compile could not be run
Description
Since the storage pool reordering process was lacking logs for troubleshooting, some debug level log messages were added and trace level log messages were changed to the debug level. Also, the log messages were rewritten according to the new Log4j2 syntax.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
How Has This Been Tested?