Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Filter accounts by domain while creating templates - from Volume / Snapshot #10455

Merged
merged 2 commits into from
Mar 3, 2025

Conversation

Pearl1594
Copy link
Contributor

Description

This PR fixes: #10301
It attempts to combine the create template Form to be used for both create template from volume as well as snapshot and also lists only those accounts belonging to the domain selected.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.21%. Comparing base (e196275) to head (6b0b058).
Report is 10 commits behind head on 4.19.

Additional details and impacted files
@@             Coverage Diff              @@
##               4.19   #10455      +/-   ##
============================================
+ Coverage     15.15%   15.21%   +0.05%     
- Complexity    11314    11437     +123     
============================================
  Files          5413     5413              
  Lines        474704   476200    +1496     
  Branches      57893    58426     +533     
============================================
+ Hits          71942    72441     +499     
- Misses       394717   395684     +967     
- Partials       8045     8075      +30     
Flag Coverage Δ
uitests 4.34% <ø> (+0.05%) ⬆️
unittests 15.93% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Pearl1594
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10455 (QA-JID-559)

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm, tested in qa

@Pearl1594 Pearl1594 linked an issue Feb 26, 2025 that may be closed by this pull request
Copy link
Collaborator

@bernardodemarco bernardodemarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, verified, in the QA environment, that the accounts are filtered correctly, according to the domain that is selected. Also verified that the API request is correctly specifying the API parameters.

@bernardodemarco bernardodemarco added this to the 4.19.3 milestone Feb 28, 2025
@DaanHoogland
Copy link
Contributor

@Pearl1594 , at your discretion (to #10455 (comment) or not to #10455 (comment))

@Pearl1594
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10455 (QA-JID-567)

@Pearl1594 Pearl1594 merged commit a9fbc6b into 4.19 Mar 3, 2025
47 of 48 checks passed
Copy link

sonarqubecloud bot commented Mar 3, 2025

@DaanHoogland DaanHoogland deleted the ui-fix-account-in-domain branch March 4, 2025 09:07
@rohityadavcloud rohityadavcloud modified the milestones: 4.19.3, 4.20.1 Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Template from Volume filter Issue
5 participants