-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Filter accounts by domain while creating templates - from Volume / Snapshot #10455
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #10455 +/- ##
============================================
+ Coverage 15.15% 15.21% +0.05%
- Complexity 11314 11437 +123
============================================
Files 5413 5413
Lines 474704 476200 +1496
Branches 57893 58426 +533
============================================
+ Hits 71942 72441 +499
- Misses 394717 395684 +967
- Partials 8045 8075 +30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm, tested in qa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, verified, in the QA environment, that the accounts are filtered correctly, according to the domain that is selected. Also verified that the API request is correctly specifying the API parameters.
@Pearl1594 , at your discretion (to #10455 (comment) or not to #10455 (comment)) |
@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✔️ |
|
Description
This PR fixes: #10301
It attempts to combine the create template Form to be used for both create template from volume as well as snapshot and also lists only those accounts belonging to the domain selected.
Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?