Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: List host OOBM details when enabled and configured #10472

Merged
merged 4 commits into from
Mar 3, 2025

Conversation

Pearl1594
Copy link
Contributor

Description

This PR fixes: #10194
Adds the OOBM details when configured and is enabled.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

image

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@Pearl1594 Pearl1594 added this to the 4.19.3 milestone Feb 26, 2025
@Pearl1594 Pearl1594 linked an issue Feb 26, 2025 that may be closed by this pull request
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.17%. Comparing base (a9fbc6b) to head (f5e2aca).
Report is 1 commits behind head on 4.19.

Additional details and impacted files
@@            Coverage Diff            @@
##               4.19   #10472   +/-   ##
=========================================
  Coverage     15.16%   15.17%           
- Complexity    11327    11329    +2     
=========================================
  Files          5413     5413           
  Lines        474778   474778           
  Branches      57905    57905           
=========================================
+ Hits          72007    72024   +17     
+ Misses       394721   394702   -19     
- Partials       8050     8052    +2     
Flag Coverage Δ
uitests 4.29% <ø> (ø)
unittests 15.89% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DaanHoogland
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10472 (QA-JID-561)

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm and works in qa:
image

however, I would expect the dialog to be filled with those values as well when re-configuring. (not sure if this would be another feature.

@Pearl1594
Copy link
Contributor Author

clgtm and works in qa: image

however, I would expect the dialog to be filled with those values as well when re-configuring. (not sure if this would be another feature.

That does make sense @DaanHoogland . This is the legacy way it behaves. I think it would be a enhancement, as we'd need to define a component for it.

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm and works in qa:
image

however, I would expect the dialog to be filled with those values as well when re-configuring. (not sure if this would be another feature.

Copy link
Contributor

@kiranchavala kiranchavala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pearl1594

Can you add the username also to the list as the older version 4.9 has it displayed

Screenshot 2025-02-28 at 3 50 30 PM

@kiranchavala
Copy link
Contributor

clgtm and works in qa: image

however, I would expect the dialog to be filled with those values as well when re-configuring. (not sure if this would be another feature.

Yes, when reconfiguring the oobm details, i would also like the details to be pre-populated like edit host

Screenshot 2025-02-28 at 4 05 00 PM

@Pearl1594
Copy link
Contributor Author

clgtm and works in qa: image
however, I would expect the dialog to be filled with those values as well when re-configuring. (not sure if this would be another feature.

Yes, when reconfiguring the oobm details, i would also like the details to be pre-populated like edit host

Screenshot 2025-02-28 at 4 05 00 PM

Can this be addressed in a separate PR @kiranchavala .

@Pearl1594
Copy link
Contributor Author

Added username as well:
image

@Pearl1594
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10472 (QA-JID-563)

Copy link
Collaborator

@bernardodemarco bernardodemarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, verified that the OOBM details are displayed in the host details page:

image

@Pearl1594
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10472 (QA-JID-566)

@Pearl1594
Copy link
Contributor Author

Comment addressed

Copy link

sonarqubecloud bot commented Mar 3, 2025

@Pearl1594 Pearl1594 merged commit a89607d into 4.19 Mar 3, 2025
47 of 48 checks passed
@DaanHoogland DaanHoogland deleted the ui-fix-host-enable-oob branch March 4, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI : Configured OOBM Mangement details are not being shown
5 participants