Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix volume allocation logs #10475

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

julien-vaz
Copy link
Contributor

Description

The logs in storage allocation algorithms were displaying incorrect information about the allocation pool. Therefore, the logs were rewritten.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

How Has This Been Tested?

When trying to migrate a volume, the expected log messages were displayed correctly.

Applies sugested changes
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 16.15%. Comparing base (24b7c66) to head (34ad14b).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
...ge/allocator/ClusterScopeStoragePoolAllocator.java 0.00% 1 Missing ⚠️
...torage/allocator/ZoneWideStoragePoolAllocator.java 0.00% 1 Missing ⚠️
.../storage/allocator/RandomStoragePoolAllocator.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              main   #10475       +/-   ##
============================================
+ Coverage     4.00%   16.15%   +12.15%     
- Complexity       0    13274    +13274     
============================================
  Files          396     5666     +5270     
  Lines        32530   498078   +465548     
  Branches      5766    60267    +54501     
============================================
+ Hits          1302    80480    +79178     
- Misses       31078   408584   +377506     
- Partials       150     9014     +8864     
Flag Coverage Δ
uitests 4.00% <ø> (-0.01%) ⬇️
unittests 17.00% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@julien-vaz
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@julien-vaz a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12667

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants