Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema: add XS 8.3, 8.4 hypervisor capabilities #10483

Draft
wants to merge 4 commits into
base: 4.20
Choose a base branch
from

Conversation

rohityadavcloud
Copy link
Member

This aims to add support for XenServer 8.4 and XCP-ng 8.3.

https://www.xenserver.com/downloads
https://mirrors.xcp-ng.org/isos/8.3/xcp-ng-8.3.0.iso?https=1

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

How Has This Been Tested?

Testing by developing support for hypervisor template with mbx, also later on with Trillian.

This aims to add support for XenServer 8.4 and XCP-ng 8.3.

Signed-off-by: Rohit Yadav <[email protected]>
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.98%. Comparing base (2d00933) to head (31123e3).

Additional details and impacted files
@@            Coverage Diff            @@
##               4.20   #10483   +/-   ##
=========================================
  Coverage     15.98%   15.98%           
- Complexity    13085    13086    +1     
=========================================
  Files          5649     5649           
  Lines        495739   495739           
  Branches      60021    60021           
=========================================
  Hits          79252    79252           
  Misses       407633   407633           
  Partials       8854     8854           
Flag Coverage Δ
uitests 4.01% <ø> (ø)
unittests 16.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DaanHoogland
Copy link
Contributor

this is double to #10470

Signed-off-by: Rohit Yadav <[email protected]>
@DaanHoogland DaanHoogland mentioned this pull request Feb 28, 2025
14 tasks
Signed-off-by: Rohit Yadav <[email protected]>
Signed-off-by: Rohit Yadav <[email protected]>
@rohityadavcloud rohityadavcloud marked this pull request as draft February 28, 2025 08:17
@rohityadavcloud
Copy link
Member Author

@DaanHoogland my bad didn't know you were working on that, I had this started as roadmap work;

Currently I've added support for the missing guest OSs and built mbx templates and verified an env is created with mbx:
https://download.cloudstack.org/templates/mbx/?new

mbx users can do a git pull and then call mbx init to refresh new templates - https://github.com/shapeblue/mbx

xcp-ng 8.3 mbx vm:
Screenshot 2025-02-28 at 11 41 01 AM

XS 8.4 mbx vm:

Screenshot 2025-02-28 at 1 51 59 PM

Currently the following issues are observed when adding the xcp or xs hosts in the zone:

  1. For XenServer 8.4.0, I see this in mgmt server logs:
2025-02-28 08:08:13,845 WARN  [c.c.h.x.d.XcpServerDiscoverer] (ApiServer-10:[ctx-02a7c0a1, ctx-fe2ae55b]) (logid:03343254) Unable to setup agent 1 due to callHostPlugin failed for cmd: setIptables with args  due to There was a failure communicating with the plugin.
  1. For XCP-ng 8.3, I see this in mgmt server logs:
2025-02-28 08:08:51,858 INFO  [c.c.r.ResourceManagerImpl] (ApiServer-10:[ctx-3f036c76, ctx-8ba28abd]) (logid:9b4870b5) Trying to add a new host at http://172.20.0.117 in data center Zone {"id": "1", "name": "DC", "uuid": "6495fda0-dc6e-4404-823c-cf7d5130049e"}
2025-02-28 08:08:51,955 WARN  [c.c.h.x.d.XcpServerDiscoverer] (ApiServer-10:[ctx-3f036c76, ctx-8ba28abd]) (logid:9b4870b5) Xml Rpc Exception org.apache.xmlrpc.client.XmlRpcClientException: Failed to parse server's response: Duplicate name: restrict_vtpm

... which seems to be discussed here https://xcp-ng.org/forum/topic/9839/java-sdk-xmlrpcclientexception-failed-to-parse-server-s-response-duplicate-name-restrict_vtpm/2?_=1740730465521 and other related thread on xcp-ng forums.

@rohityadavcloud
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@DaanHoogland
Copy link
Contributor

np @rohityadavcloud (just hate doing double work ;)

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12615

@rohityadavcloud
Copy link
Member Author

@blueorangutan help

@blueorangutan
Copy link

@rohityadavcloud [SL] I understand these words: "help", "hello", "thanks", "package", "test"
Test command usage: test [mgmt os] [hypervisor] [keepEnv] [qemuEv] [basicZone|securityGroups]
Mgmt OS options: ['ol8', 'ol9', 'debian12', 'rocky8', 'alma9', 'suse15', 'centos7', 'centos6', 'alma8', 'ubuntu18', 'ubuntu22', 'ubuntu20', 'ubuntu24']
Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-rocky8', 'kvm-ol8', 'kvm-ol9', 'kvm-alma8', 'kvm-alma9', 'kvm-ubuntu18', 'kvm-ubuntu20', 'kvm-ubuntu22', 'kvm-ubuntu24', 'kvm-debian12', 'kvm-suse15', 'vmware-55u3', 'vmware-60u2', 'vmware-65u2', 'vmware-67u3', 'vmware-70u1', 'vmware-70u2', 'vmware-70u3', 'vmware-80', 'vmware-80u1', 'vmware-80u2', 'vmware-80u3', 'xenserver-65sp1', 'xenserver-71', 'xenserver-74', 'xcpng74', 'xcpng76', 'xcpng80', 'xcpng81', 'xcpng82']
Note: when keepEnv is passed, you need to specify mgmt server os and hypervisor or use the matrix command.
when qemuEv is passed, it will deploy KVM hyperviosr hosts with qemu-kvm-ev, else it will default to stock qemu.
When basicZone and/or securityGroups are passed it will create a zone of the last type specified (default is Advanced)
Package command usage: package [all(default value),kvm,xen,vmware,hyperv,ovm] - a comma separated list can be passed with package command to bundle the required hypervisor's systemVM templates. Not passing any argument will bundle all - kvm,xen and vmware templates.

Blessed contributors for kicking Trillian test jobs: ['rohityadavcloud', 'shwstppr', 'vishesh92', 'Pearl1594', 'harikrishna-patnala', 'nvazquez', 'DaanHoogland', 'weizhouapache', 'borisstoyanov', 'vladimirpetrov', 'kiranchavala', 'andrijapanicsb', 'NuxRo', 'rajujith', 'alexandremattioli', 'sureshanaparti', 'abh1sar', 'sudo87']

@rohityadavcloud
Copy link
Member Author

@blueorangutan test ol8 xcpng82

@blueorangutan
Copy link

@rohityadavcloud a [SL] Trillian-Jenkins test job (ol8 mgmt + xcpng82) has been kicked to run smoke tests

@rohityadavcloud
Copy link
Member Author

@blueorangutan test ol8 xcpng82

@blueorangutan
Copy link

@rohityadavcloud a [SL] Trillian-Jenkins test job (ol8 mgmt + xcpng82) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-12537)
Environment: xcpng82 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 73313 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10483-t12537-xcpng82.zip
Smoke tests completed. 135 look OK, 6 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_condensed_drs_algorithm Failure 163.98 test_cluster_drs.py
test_02_balanced_drs_algorithm Failure 184.20 test_cluster_drs.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup Error 10.52 test_network.py
test_01_non_strict_host_anti_affinity Error 229.11 test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity Error 116.31 test_nonstrict_affinity_group.py
test_06_purge_expunged_vm_background_task Failure 396.52 test_purge_expunged_vms.py
test_02_create_volume Error 2.22 test_resource_names.py
test_05_scale_vm_dont_allow_disk_offering_change Failure 72.83 test_scale_vm.py

@rohityadavcloud
Copy link
Member Author

@blueorangutan test ol9 xenserver-71

@blueorangutan
Copy link

@rohityadavcloud a [SL] Trillian-Jenkins test job (ol9 mgmt + xenserver-71) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-12547)

@rohityadavcloud
Copy link
Member Author

@blueorangutan test ol8 xenserver-71

@blueorangutan
Copy link

@rohityadavcloud a [SL] Trillian-Jenkins test job (ol8 mgmt + xenserver-71) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-12554)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 57067 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10483-t12554-xenserver-71.zip
Smoke tests completed. 136 look OK, 5 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_delete_global_acl Failure 3.67 test_global_acls.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup Error 3.35 test_network.py
test_06_purge_expunged_vm_background_task Failure 402.59 test_purge_expunged_vms.py
test_02_create_volume Error 3.21 test_resource_names.py
test_02_cancel_host_maintenace_with_migration_jobs Error 1515.64 test_host_maintenance.py

@blueorangutan
Copy link

[SF] Trillian test result (tid-12544)
Environment: xcpng82 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 76160 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10483-t12544-xcpng82.zip
Smoke tests completed. 135 look OK, 6 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_condensed_drs_algorithm Failure 165.12 test_cluster_drs.py
test_02_balanced_drs_algorithm Failure 200.64 test_cluster_drs.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup Error 11.68 test_network.py
test_01_non_strict_host_anti_affinity Error 225.22 test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity Error 108.03 test_nonstrict_affinity_group.py
test_06_purge_expunged_vm_background_task Failure 423.02 test_purge_expunged_vms.py
test_02_create_volume Error 3.25 test_resource_names.py
test_05_scale_vm_dont_allow_disk_offering_change Failure 66.58 test_scale_vm.py

@Pearl1594
Copy link
Contributor

@blueorangutan help

@blueorangutan
Copy link

@Pearl1594 [SL] I understand these words: "help", "hello", "thanks", "package", "test"
Test command usage: test [mgmt os] [hypervisor] [keepEnv] [qemuEv] [basicZone|securityGroups]
Mgmt OS options: ['ol8', 'ol9', 'debian12', 'rocky8', 'alma9', 'suse15', 'centos7', 'centos6', 'alma8', 'ubuntu18', 'ubuntu22', 'ubuntu20', 'ubuntu24']
Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-rocky8', 'kvm-ol8', 'kvm-ol9', 'kvm-alma8', 'kvm-alma9', 'kvm-ubuntu18', 'kvm-ubuntu20', 'kvm-ubuntu22', 'kvm-ubuntu24', 'kvm-debian12', 'kvm-suse15', 'vmware-55u3', 'vmware-60u2', 'vmware-65u2', 'vmware-67u3', 'vmware-70u1', 'vmware-70u2', 'vmware-70u3', 'vmware-80', 'vmware-80u1', 'vmware-80u2', 'vmware-80u3', 'xenserver-65sp1', 'xenserver-71', 'xenserver-74', 'xenserver-84', 'xcpng74', 'xcpng76', 'xcpng80', 'xcpng81', 'xcpng82', 'xcpng83']
Note: when keepEnv is passed, you need to specify mgmt server os and hypervisor or use the matrix command.
when qemuEv is passed, it will deploy KVM hyperviosr hosts with qemu-kvm-ev, else it will default to stock qemu.
When basicZone and/or securityGroups are passed it will create a zone of the last type specified (default is Advanced)
Package command usage: package [all(default value),kvm,xen,vmware,hyperv,ovm] - a comma separated list can be passed with package command to bundle the required hypervisor's systemVM templates. Not passing any argument will bundle all - kvm,xen and vmware templates.

Blessed contributors for kicking Trillian test jobs: ['rohityadavcloud', 'shwstppr', 'vishesh92', 'Pearl1594', 'harikrishna-patnala', 'nvazquez', 'DaanHoogland', 'weizhouapache', 'borisstoyanov', 'vladimirpetrov', 'kiranchavala', 'andrijapanicsb', 'NuxRo', 'rajujith', 'alexandremattioli', 'sureshanaparti', 'abh1sar', 'sudo87']

@apache apache deleted a comment from blueorangutan Mar 11, 2025
@apache apache deleted a comment from blueorangutan Mar 11, 2025
@apache apache deleted a comment from blueorangutan Mar 11, 2025
@apache apache deleted a comment from blueorangutan Mar 11, 2025
@apache apache deleted a comment from blueorangutan Mar 11, 2025
@apache apache deleted a comment from blueorangutan Mar 11, 2025
@apache apache deleted a comment from blueorangutan Mar 11, 2025
@Pearl1594
Copy link
Contributor

@blueorangutan test ol8 xenserver-84

@blueorangutan
Copy link

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + xenserver-84) has been kicked to run smoke tests

@Pearl1594
Copy link
Contributor

@blueorangutan test ol8 xcpng83

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-12658)

@blueorangutan
Copy link

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + xcpng83) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-12659)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants