Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Add View ISOs button to the account details pages #10488

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bernardodemarco
Copy link
Collaborator

@bernardodemarco bernardodemarco commented Mar 1, 2025

Description

The InfoCard component on the account details pages provides several buttons to view the resources associated to an account. However, currently, there isn't a button to view an account's ISOs.

Therefore, this PR, similarly to what has been done on #10425, adds the View ISOs button in the accounts InfoCard component. Additionally, as mentioned on #10393 (comment), support for filtering templates and ISOs by domain will be handled on separate PRs.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

image

How Has This Been Tested?

Verified that when selecting the View ISOs button in an account's InfoCard, the UI redirects the user to the following URL: /iso?isofilter=self&filter=self&account=<account>&domainid=<domain-uuid>.

@bernardodemarco
Copy link
Collaborator Author

@blueorangutan ui

@bernardodemarco bernardodemarco added this to the 4.21.0 milestone Mar 1, 2025
@blueorangutan
Copy link

@bernardodemarco a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

Copy link

codecov bot commented Mar 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.15%. Comparing base (69cf299) to head (db59f08).

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #10488      +/-   ##
============================================
- Coverage     16.15%   16.15%   -0.01%     
  Complexity    13273    13273              
============================================
  Files          5666     5666              
  Lines        498081   498084       +3     
  Branches      60267    60268       +1     
============================================
- Hits          80475    80473       -2     
- Misses       408593   408605      +12     
+ Partials       9013     9006       -7     
Flag Coverage Δ
uitests 4.00% <ø> (-0.01%) ⬇️
unittests 17.00% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10488 (QA-JID-565)

Copy link
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants