-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Add View ISOs
button to the account details pages
#10488
base: main
Are you sure you want to change the base?
UI: Add View ISOs
button to the account details pages
#10488
Conversation
@bernardodemarco a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10488 +/- ##
============================================
- Coverage 16.15% 16.15% -0.01%
Complexity 13273 13273
============================================
Files 5666 5666
Lines 498081 498084 +3
Branches 60267 60268 +1
============================================
- Hits 80475 80473 -2
- Misses 408593 408605 +12
+ Partials 9013 9006 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
UI build: ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
The
InfoCard
component on the account details pages provides several buttons to view the resources associated to an account. However, currently, there isn't a button to view an account's ISOs.Therefore, this PR, similarly to what has been done on #10425, adds the
View ISOs
button in the accountsInfoCard
component. Additionally, as mentioned on #10393 (comment), support for filtering templates and ISOs by domain will be handled on separate PRs.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
How Has This Been Tested?
Verified that when selecting the
View ISOs
button in an account'sInfoCard
, the UI redirects the user to the following URL:/iso?isofilter=self&filter=self&account=<account>&domainid=<domain-uuid>
.