test: fix failure in test_purge_expunged_vms.py

[shwstppr]

Description

Seen in #10006 (comment) and other test runs.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Ran test after changes,

root@pr10006-t12482-kvm-ol8-marvin marvin]# nosetests --with-xunit --xunit-file=results.xml --with-marvin --marvin-config=./pr10006-t12482-kvm-ol8-advanced-cfg -s -a tags=advanced --hypervisor=KVM tests/smoke/test_purge_expunged_vms.py 
/usr/local/lib/python3.6/site-packages/paramiko/transport.py:32: CryptographyDeprecationWarning: Python 3.6 is no longer supported by the Python core team. Therefore, support for it is deprecated in cryptography. The next release of cryptography will remove support for Python 3.6.
  from cryptography.hazmat.backends import default_backend

==== Marvin Init Started ====

=== Marvin Parse Config Successful ===

=== Marvin Setting TestData Successful===

==== Log Folder Path: /marvin/MarvinLogs/Mar_03_2025_05_38_49_VUX70X All logs will be available here ====

=== Marvin Init Logging Successful===

==== Marvin Init Successful ====
=== TestName: test_01_purge_expunged_api_vm_start_date | Status : SUCCESS ===

=== TestName: test_02_purge_expunged_api_vm_end_date | Status : SUCCESS ===

=== TestName: test_03_purge_expunged_api_vm_start_end_date | Status : SUCCESS ===

=== TestName: test_04_purge_expunged_api_vm_no_date | Status : SUCCESS ===

=== TestName: test_05_purge_expunged_vm_service_offering | Status : SUCCESS ===

====Trying SSH Connection: Host:10.0.34.25 User:root                                   Port:22 RetryCnt:60===
===SSH to Host 10.0.34.25 port : 22 SUCCESSFUL===
{Cmd: service cloudstack-management stop via Host: 10.0.34.25} {returns: ['Redirecting to /bin/systemctl stop cloudstack-management.service']}
{Cmd: service cloudstack-management start via Host: 10.0.34.25} {returns: ['Redirecting to /bin/systemctl start cloudstack-management.service']}
====Trying SSH Connection: Host:None User:root                                   Port:22 RetryCnt:60===
====Trying SSH Connection: Host:None User:root                                   Port:22 RetryCnt:60===
===SSH to Host None port : 22 SUCCESSFUL===
===SSH to Host None port : 22 SUCCESSFUL===
{Cmd: service cloudstack-management stop via Host: None} {returns: ['Redirecting to /bin/systemctl stop cloudstack-management.service', 'Failed to stop cloudstack-management.service: Unit cloudstack-management.service not loaded.']}
{Cmd: service cloudstack-management start via Host: None} {returns: ['Redirecting to /bin/systemctl start cloudstack-management.service', 'Failed to start cloudstack-management.service: Unit not found.']}
====Trying SSH Connection: Host:10.0.34.25 User:root                                   Port:22 RetryCnt:60===
====Trying SSH Connection: Host:10.0.34.25 User:root                                   Port:22 RetryCnt:60===
===SSH to Host 10.0.34.25 port : 22 SUCCESSFUL===
===SSH to Host 10.0.34.25 port : 22 SUCCESSFUL===
{Cmd: service cloudstack-management stop via Host: 10.0.34.25} {returns: ['Redirecting to /bin/systemctl stop cloudstack-management.service']}
{Cmd: service cloudstack-management stop via Host: 10.0.34.25} {returns: ['Redirecting to /bin/systemctl stop cloudstack-management.service']}
{Cmd: service cloudstack-management start via Host: 10.0.34.25} {returns: ['Redirecting to /bin/systemctl start cloudstack-management.service']}
{Cmd: service cloudstack-management start via Host: 10.0.34.25} {returns: ['Redirecting to /bin/systemctl start cloudstack-management.service']}
====Trying SSH Connection: Host:None User:root                                   Port:22 RetryCnt:60===
====Trying SSH Connection: Host:None User:root                                   Port:22 RetryCnt:60===
====Trying SSH Connection: Host:None User:root                                   Port:22 RetryCnt:60===
===SSH to Host None port : 22 SUCCESSFUL===
===SSH to Host None port : 22 SUCCESSFUL===
===SSH to Host None port : 22 SUCCESSFUL===
{Cmd: service cloudstack-management stop via Host: None} {returns: ['Redirecting to /bin/systemctl stop cloudstack-management.service', 'Failed to stop cloudstack-management.service: Unit cloudstack-management.service not loaded.']}
{Cmd: service cloudstack-management stop via Host: None} {returns: ['Redirecting to /bin/systemctl stop cloudstack-management.service', 'Failed to stop cloudstack-management.service: Unit cloudstack-management.service not loaded.']}
{Cmd: service cloudstack-management start via Host: None} {returns: ['Redirecting to /bin/systemctl start cloudstack-management.service', 'Failed to start cloudstack-management.service: Unit not found.']}
{Cmd: service cloudstack-management start via Host: None} {returns: ['Redirecting to /bin/systemctl start cloudstack-management.service', 'Failed to start cloudstack-management.service: Unit not found.']}
=== TestName: test_06_purge_expunged_vm_background_task | Status : SUCCESS ===

=== Final results are now copied to: /marvin//MarvinLogs/test_purge_expunged_vms_SIBUW4 ===

How did you try to break this feature and the system with this change?

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.98%. Comparing base (bdae23e) to head (ea61260).

Additional details and impacted files

@@            Coverage Diff            @@
##               4.20   #10490   +/-   ##
=========================================
  Coverage     15.98%   15.98%           
- Complexity    13084    13086    +2     
=========================================
  Files          5649     5649           
  Lines        495741   495741           
  Branches      60022    60022           
=========================================
+ Hits          79250    79260   +10     
+ Misses       407635   407627    -8     
+ Partials       8856     8854    -2     

Flag	Coverage Δ
uitests	4.01% <ø> (ø)
unittests	16.82% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12633

[shwstppr]

@blueorangutan test

[blueorangutan]

@shwstppr a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[weizhouapache]

code lgtm

[shwstppr]

The fix is not the reason for failure. Will investigate and rework.

[blueorangutan]

[SF] Trillian test result (tid-12534)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 55332 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10490-t12534-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_06_purge_expunged_vm_background_task	Failure	386.19	test_purge_expunged_vms.py