Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ConfigDrive with VPC #10495

Draft
wants to merge 1 commit into
base: 4.20
Choose a base branch
from

Conversation

vishesh92
Copy link
Member

Description

This PR fixes #9706

Generated summary

This pull request includes changes to enhance the capabilities and provider configurations for DHCP and DNS services. The changes primarily involve updating the configuration in both the backend and frontend code.

Backend changes:

Frontend changes:

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@vishesh92
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.98%. Comparing base (b92fd17) to head (055c76f).

Additional details and impacted files
@@            Coverage Diff            @@
##               4.20   #10495   +/-   ##
=========================================
  Coverage     15.98%   15.98%           
+ Complexity    13086    13085    -1     
=========================================
  Files          5650     5650           
  Lines        495756   495756           
  Branches      60018    60018           
=========================================
+ Hits          79261    79262    +1     
  Misses       407641   407641           
+ Partials       8854     8853    -1     
Flag Coverage Δ
uitests 4.00% <ø> (ø)
unittests 16.82% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12647

@vishesh92
Copy link
Member Author

@blueorangutan test keepEnv

@blueorangutan
Copy link

@vishesh92 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-12556)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 58476 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10495-t12556-kvm-ol8.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_deployVMInSharedNetwork Failure 5.48 test_network.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:teardown Error 6.58 test_network.py
test_06_purge_expunged_vm_background_task Failure 399.86 test_purge_expunged_vms.py

@Pearl1594 Pearl1594 linked an issue Mar 5, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ConfigDrive option in VPC network offerings
2 participants