Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compute.js #10532

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update compute.js #10532

wants to merge 1 commit into from

Conversation

Pablogp2005
Copy link

@Pablogp2005 Pablogp2005 commented Mar 9, 2025

Description

This PR...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copy link

boring-cyborg bot commented Mar 9, 2025

Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
Here are some useful points:

@DaanHoogland
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

Comment on lines +1048 to +1072
tabs: [
{
name: 'details',
component: () => import('@/components/view/DetailsTab.vue')
},
{
name: 'ayuda',
component: {
template:
<div>
<h3>Guía rápida</h3>
<ul>
<li><strong>Estado:</strong> Running indica que la VM está activa.</li>
<li><strong>IP Pública:</strong> Usada para acceder desde Internet.</li>
<li><strong>Snapshots:</strong> Copias de seguridad rápidas.</li>
<li><strong>Plantilla:</strong> para compatibilidad, Linux para servidores.</li>
<li><strong>RAM:</strong> mínima: 2GB para pruebas, 8GB para producción.</li>
<li><strong>Número de CPUS:</strong> mejoran rendimiento pero consumen más recursos.</li>

</ul>
</div>

}
}
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about the intention, but I am absolutly sure this should be solved in a different way.

@blueorangutan
Copy link

UI build failed: ✖️
(SL-JID-571)

Copy link

codecov bot commented Mar 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.02%. Comparing base (1c1dad9) to head (9e82910).

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #10532      +/-   ##
============================================
+ Coverage     16.17%   17.02%   +0.85%     
+ Complexity    13291    13289       -2     
============================================
  Files          5668     5270     -398     
  Lines        498179   465598   -32581     
  Branches      60290    54514    -5776     
============================================
- Hits          80581    79284    -1297     
+ Misses       408578   377441   -31137     
+ Partials       9020     8873     -147     
Flag Coverage Δ
uitests ?
unittests 17.02% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please explain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants