Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with crosssite api call after login. #10533

Draft
wants to merge 5 commits into
base: 4.20
Choose a base branch
from

Conversation

DaanHoogland
Copy link
Contributor

Description

This PR...

Fixes: #10522

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copy link

codecov bot commented Mar 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.00%. Comparing base (b8359e8) to head (8aae38e).

Additional details and impacted files
@@            Coverage Diff            @@
##               4.20   #10533   +/-   ##
=========================================
  Coverage     16.00%   16.00%           
+ Complexity    13104    13103    -1     
=========================================
  Files          5651     5651           
  Lines        495841   495842    +1     
  Branches      60044    60044           
=========================================
+ Hits          79365    79368    +3     
  Misses       407613   407613           
+ Partials       8863     8861    -2     
Flag Coverage Δ
uitests 4.00% <ø> (-0.01%) ⬇️
unittests 16.84% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DaanHoogland DaanHoogland requested a review from vishesh92 March 10, 2025 09:31
@apache apache deleted a comment from blueorangutan Mar 10, 2025
@apache apache deleted a comment from blueorangutan Mar 10, 2025
@apache apache deleted a comment from blueorangutan Mar 10, 2025
@apache apache deleted a comment from blueorangutan Mar 10, 2025
@apache apache deleted a comment from blueorangutan Mar 10, 2025
@apache apache deleted a comment from blueorangutan Mar 10, 2025
@apache apache deleted a comment from blueorangutan Mar 10, 2025
@apache apache deleted a comment from blueorangutan Mar 10, 2025
@DaanHoogland
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10533 (QA-JID-575)

@vishesh92
Copy link
Member

@blueorangutan package

@blueorangutan
Copy link

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 12718

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12719

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Two API requests done towards api.github.com anytime someone visits ACS UI
3 participants