Skip to content

Make kvm domain persistent when unmanaged from CS #11541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harikrishna-patnala merged 20 commits into from
Oct 7, 2025

include import unmanaged instance fix from #11753

4e36aa1
Select commit
Loading
Failed to load commit list.
Merged

Make kvm domain persistent when unmanaged from CS #11541

include import unmanaged instance fix from #11753
4e36aa1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 29, 2025 in 1s

17.53% (+0.10%) compared to ec533cd

View this Pull Request on Codecov

17.53% (+0.10%) compared to ec533cd

Details

Codecov Report

❌ Patch coverage is 55.50847% with 105 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.53%. Comparing base (ec533cd) to head (4e36aa1).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...wrapper/LibvirtUnmanageInstanceCommandWrapper.java 32.91% 51 Missing and 2 partials ⚠️
...ck/api/command/admin/vm/UnmanageVMInstanceCmd.java 0.00% 13 Missing ⚠️
...a/com/cloud/agent/api/UnmanageInstanceCommand.java 50.00% 12 Missing ⚠️
...n/java/com/cloud/vm/VirtualMachineManagerImpl.java 88.37% 5 Missing and 5 partials ⚠️
...stack/api/response/UnmanageVMInstanceResponse.java 0.00% 6 Missing ⚠️
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java 58.33% 5 Missing ⚠️
.../apache/cloudstack/vm/UnmanagedVMsManagerImpl.java 61.53% 0 Missing and 5 partials ⚠️
...va/com/cloud/agent/api/UnmanageInstanceAnswer.java 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #11541      +/-   ##
============================================
+ Coverage     17.42%   17.53%   +0.10%     
- Complexity    15336    15461     +125     
============================================
  Files          5892     5897       +5     
  Lines        526521   527054     +533     
  Branches      64293    64359      +66     
============================================
+ Hits          91767    92430     +663     
+ Misses       424401   424231     -170     
- Partials      10353    10393      +40

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov