Skip to content

extension/proxmox: add console access for instances #11601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shwstppr merged 16 commits into from
Sep 27, 2025

change

1e911a9
Select commit
Loading
Failed to load commit list.
Merged

extension/proxmox: add console access for instances #11601

change
1e911a9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 26, 2025 in 0s

17.50% (+0.10%) compared to 0526ec0

View this Pull Request on Codecov

17.50% (+0.10%) compared to 0526ec0

Details

Codecov Report

❌ Patch coverage is 66.98113% with 140 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.50%. Comparing base (0526ec0) to head (1e911a9).
⚠️ Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
...com/cloud/agent/api/GetExternalConsoleCommand.java 0.00% 21 Missing ⚠️
.../com/cloud/consoleproxy/vnc/network/NioSocket.java 0.00% 16 Missing ⚠️
.../com/cloud/agent/api/GetExternalConsoleAnswer.java 48.27% 15 Missing ⚠️
...udstack/consoleproxy/ConsoleAccessManagerImpl.java 92.81% 9 Missing and 4 partials ⚠️
...al/provisioner/ExternalPathPayloadProvisioner.java 83.56% 7 Missing and 5 partials ⚠️
...work/extensions/manager/ExtensionsManagerImpl.java 75.55% 2 Missing and 9 partials ⚠️
...om/cloud/consoleproxy/ConsoleProxyClientParam.java 0.00% 9 Missing ⚠️
...in/java/com/cloud/servlet/ConsoleProxyServlet.java 0.00% 8 Missing ⚠️
...om/cloud/consoleproxy/ConsoleProxyNoVncClient.java 0.00% 8 Missing ⚠️
...hypervisor/external/resource/ExternalResource.java 0.00% 7 Missing ⚠️
... and 7 more
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #11601      +/-   ##
============================================
+ Coverage     17.39%   17.50%   +0.10%     
- Complexity    15285    15425     +140     
============================================
  Files          5889     5894       +5     
  Lines        526183   526836     +653     
  Branches      64242    64331      +89     
============================================
+ Hits          91542    92228     +686     
+ Misses       424297   424231      -66     
- Partials      10344    10377      +33

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov