Refactor updateDiskOffering API

[hsato03]

Description

This PR intends to refactor the updateDiskOffering API due to its size.

This method was separated into others in order to improve the readability of the disk offering update process.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

I called the updateDiskOffering API and it is working as it did before the refactoring. I also created some unit tests to maintain the current behavior and avoid regressions in the future.

[DaanHoogland]

clgtm and unit tests added

[codecov]

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (9d4f071) 30.80% compared to head (ef290c1) 30.89%.
Report is 54 commits behind head on 4.19.

Files	Patch %	Lines
.../cloud/configuration/ConfigurationManagerImpl.java	68.75%	14 Missing and 11 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19    #8446      +/-   ##
============================================
+ Coverage     30.80%   30.89%   +0.08%     
- Complexity    33981    34137     +156     
============================================
  Files          5341     5353      +12     
  Lines        374864   375926    +1062     
  Branches      54518    54622     +104     
============================================
+ Hits         115485   116125     +640     
- Misses       244114   244489     +375     
- Partials      15265    15312      +47     

Flag	Coverage Δ
simulator-marvin-tests	24.68% <38.75%> (-0.05%)	⬇️
uitests	4.38% <ø> (-0.02%)	⬇️
unit-tests	16.62% <36.25%> (+0.16%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[GutoVeronezi]

CLGTM

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8684

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-9262)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44031 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8446-t9262-kvm-centos7.zip
Smoke tests completed. 129 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File