Add IOPS to disk offerings details

[hsato03]

Description

When listing disk offerings through the UI, IOPS and read/write data for these offerings is not presented, making it difficult to access information about them.

For this reason, Disk Read Rate (IOPS), Disk Write Rate (IOPS), Disk Read Rate (BPS), Disk Write Rate (BPS) and Max IOPS data has been added to the disk offering details.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

1. I created a disk offering with customized write and read rate values using the hypervisor QoS type in the creation form;
2. I created a disk offering with max IOPS using the storage QoS type in the creation form;
3. I accessed these disk offerings and verified that the Disk Read Rate (IOPS), Disk Write Rate (IOPS), Disk Read Rate (BPS), Disk Write Rate (BPS) data were in the disk offering created in the step 1 and the Max IOPS data was in the disk offering created in the step 2.

[DaanHoogland]

clgtm

[DaanHoogland]

@blueorangutan ui

[blueorangutan]

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[codecov]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9d4f071) 30.80% compared to head (dc91998) 30.42%.
Report is 17 commits behind head on main.

Files	Patch %	Lines
ui/src/config/section/offering.js	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #8447      +/-   ##
============================================
- Coverage     30.80%   30.42%   -0.38%     
+ Complexity    33981    33567     -414     
============================================
  Files          5341     5341              
  Lines        374864   374918      +54     
  Branches      54518    54534      +16     
============================================
- Hits         115485   114078    -1407     
- Misses       244114   245692    +1578     
+ Partials      15265    15148     -117     

Flag	Coverage Δ
simulator-marvin-tests	24.25% <ø> (-0.48%)	⬇️
uitests	4.39% <0.00%> (ø)
unit-tests	16.46% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8447 (QA-JID-253)

[DaanHoogland]

not sure why, but in qa this doesn't work, @hsato03. I will try building a 4.19 env to double check. (qa is 4.18.1)

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8214

[hsato03]

not sure why, but in qa this doesn't work, @hsato03. I will try building a 4.19 env to double check. (qa is 4.18.1)

@DaanHoogland thanks. I have tested on https://qa.cloudstack.cloud/simulator/pr/8447 and it seems to be working.

Could you explain how you did the tests?

[DaanHoogland]

yes verified. don't know what happened.

[kiranchavala]

@blueorangutan ui

[blueorangutan]

@kiranchavala a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8447 (QA-JID-256)

[kiranchavala]

@hsato03

Could you please include "miniops" in the disk offering details.

If a disk offering is created with min IOPS using the storage QoS

[hsato03]

@hsato03

Could you please include "miniops" in the disk offering details.

If a disk offering is created with min IOPS using the storage QoS

@kiranchavala thanks for your review. I added the min IOPS to the disk offering details.

[kiranchavala]

@blueorangutan ui

[blueorangutan]

@kiranchavala a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8447 (QA-JID-259)

[kiranchavala]

LGTM , Please find the screenshots

[hsato03]

Hello guys,

Any other concerns about this one?