Skip to content

Image Store: View Access status of the image store and view events#8467

Merged
yadvr merged 1 commit into4.19from
fix-ss-access-status
Feb 5, 2024
Merged

Image Store: View Access status of the image store and view events#8467
yadvr merged 1 commit into4.19from
fix-ss-access-status

Conversation

@Pearl1594
Copy link
Contributor

Description

This PR fixes the issue #8441

  • Access details of image store isn't visible
  • No events present for update to image store access status

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (33e2a4d) 30.77% compared to head (0b23939) 29.75%.
Report is 23 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8467      +/-   ##
============================================
- Coverage     30.77%   29.75%   -1.03%     
+ Complexity    33953    32748    -1205     
============================================
  Files          5341     5341              
  Lines        374855   376434    +1579     
  Branches      54517    55133     +616     
============================================
- Hits         115379   112023    -3356     
- Misses       244219   249532    +5313     
+ Partials      15257    14879     -378     
Flag Coverage Δ
simulator-marvin-tests 23.22% <100.00%> (-1.47%) ⬇️
uitests 4.36% <ø> (-0.04%) ⬇️
unit-tests 16.52% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 8, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

3 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@vishesh92 vishesh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@kiranchavala
Copy link
Member

@blueorangutan package

@blueorangutan
Copy link

@kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8244

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm, not sure about the functionality of making a secstor read-only and then read/write again though. needs diligent testing.

Copy link
Member

@kiranchavala kiranchavala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Tested manually and the Access and event status is displayed

Screenshot 2024-01-09 at 4 04 18 PM Screenshot 2024-01-09 at 4 04 10 PM

Copy link
Contributor

@BryanMLima BryanMLima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLGTM

@DaanHoogland DaanHoogland added this to the 4.19.1.0 milestone Jan 22, 2024
@yadvr yadvr changed the base branch from main to 4.19 February 5, 2024 08:47
@yadvr yadvr merged commit 5361b41 into 4.19 Feb 5, 2024
@yadvr yadvr deleted the fix-ss-access-status branch February 5, 2024 08:47
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

Updating the secondary storage to readonly or readwrite doesn't show in the UI (Access)

7 participants