Skip to content

Update server.properties.in#8509

Merged
yadvr merged 1 commit into4.19from
ap-server-properties-text-update
Feb 5, 2024
Merged

Update server.properties.in#8509
yadvr merged 1 commit into4.19from
ap-server-properties-text-update

Conversation

@andrijapanicsb
Copy link
Contributor

Minor grammar and link update.

Grammar and link corrections.
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@codecov
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c3b77cb) 18.28% compared to head (cfb6639) 32.08%.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #8509       +/-   ##
=============================================
+ Coverage     18.28%   32.08%   +13.80%     
- Complexity    16826    32862    +16036     
=============================================
  Files          4848     4980      +132     
  Lines        324301   346349    +22048     
  Branches      45561    49553     +3992     
=============================================
+ Hits          59290   111119    +51829     
+ Misses       256437   220426    -36011     
- Partials       8574    14804     +6230     
Flag Coverage Δ
simulator-marvin-tests 23.45% <ø> (+5.17%) ⬆️
unit-tests 16.49% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@JoaoJandre JoaoJandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm

@yadvr yadvr modified the milestones: 4.20.0.0, 4.19.1.0 Feb 5, 2024
@yadvr yadvr changed the base branch from main to 4.19 February 5, 2024 08:54
@yadvr yadvr merged commit c0643a8 into 4.19 Feb 5, 2024
@yadvr yadvr deleted the ap-server-properties-text-update branch February 5, 2024 08:54
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Feb 7, 2024
Grammar and link corrections.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

5 participants