Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.18 #8543 +/- ##
=============================================
- Coverage 12.93% 12.23% -0.71%
- Complexity 8944 9290 +346
=============================================
Files 2715 4698 +1983
Lines 256107 414257 +158150
Branches 39938 51114 +11176
=============================================
+ Hits 33139 50702 +17563
- Misses 218808 357254 +138446
- Partials 4160 6301 +2141
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
|
@OlegChuev any opinion on our comments? we are planning for 4.18.2 and it would be nice to resolve this before then. |
yadvr
reviewed
Jun 10, 2024
yadvr
approved these changes
Jun 10, 2024
Member
|
@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
shwstppr
approved these changes
Jun 10, 2024
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Jun 17, 2024
* Updated units names * Update ui/public/locales/en.json * Update ui/public/locales/en.json --------- Co-authored-by: Rohit Yadav <rohityadav89@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR...
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?
Before the fix
After the fix
