Fixup vm powerstate update by vishesh92 · Pull Request #8545 · apache/cloudstack

vishesh92 · 2024-01-22T17:34:05Z

Description

We discovered this issue in one of our envs where a VM was running on the host but the state of the VM in the host was Stopped. Ideally power reports should have fixed this, but it didn't.

This PR addresses below, to ensure power state in sync with the instance state.

allows the VM state update through power state report handler when there is a mismatch in power state - PowerOn, PowerOff and instance state - Stopped, Running respectively, that is when
- VM is in stopped state and power report is powerOn
- VM is in running state and power report is powerOff
  It sends an update (publishes a message on Topic VM_POWER_STATE). The subscriber on this topic transits the VM as per the state & powerstate.
resets the power state update counter before VM migration, which allows power state report handler to update with proper state / host.
updates power state to 'PowerOff' when VM is stopped.

I wasn't able to reproduce the issue. But updating the entry for vm_instance in the database helps.

Launch a VM and ensure it's running.
Run the below update query for the instance

UPDATE vm_instance SET state = 'Stopped', power_state_update_count = 3 where id = 12345;

It should switch back to 'Running' after next power state update, but it doesn't happen.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Tested power / instance state mismatch with manual db update
Tested VM migration, and confirmed the power state counter reset
Tested VM stop, and confirmed power state set to 'PowerOff'

After these changes, I was not able to reproduce the issue by running update query mentioned above.

How did you try to break this feature and the system with this change?

vishesh92 · 2024-01-22T17:34:17Z

@blueorangutan package

blueorangutan · 2024-01-22T17:36:03Z

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2024-01-22T18:11:59Z

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (c795547) 20.99% compared to head (cc8bd7b) 30.83%.
Report is 26 commits behind head on 4.19.

Files	Patch %	Lines
.../main/java/com/cloud/vm/dao/VMInstanceDaoImpl.java	81.81%	0 Missing and 2 partials ⚠️
...n/java/com/cloud/vm/VirtualMachineManagerImpl.java	75.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19    #8545      +/-   ##
============================================
+ Coverage     20.99%   30.83%   +9.83%     
- Complexity    19683    34073   +14390     
============================================
  Files          4849     5346     +497     
  Lines        324441   375431   +50990     
  Branches      45573    54600    +9027     
============================================
+ Hits          68121   115763   +47642     
+ Misses       246563   244370    -2193     
- Partials       9757    15298    +5541

Flag	Coverage Δ
simulator-marvin-tests	`24.69% <53.33%> (+3.70%)`	⬆️
uitests	`4.39% <ø> (?)`
unit-tests	`16.55% <46.66%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

blueorangutan · 2024-01-22T18:41:37Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8409

vishesh92 · 2024-01-22T18:51:47Z

@blueorangutan test

blueorangutan · 2024-01-22T18:52:03Z

@vishesh92 a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

engine/schema/src/main/java/com/cloud/vm/dao/VMInstanceDaoImpl.java

vishesh92 · 2024-02-02T08:21:27Z

@blueorangutan package

blueorangutan · 2024-02-02T08:22:03Z

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-02-02T09:23:16Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8493

sureshanaparti · 2024-02-02T09:53:41Z

@blueorangutan test matrix

blueorangutan · 2024-02-02T09:54:03Z

@sureshanaparti a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan · 2024-02-03T02:01:27Z

[SF] Trillian test result (tid-9045)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 56486 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8545-t9045-kvm-centos7.zip
Smoke tests completed. 120 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL	`Failure`	1100.03	test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers	`Failure`	453.59	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Failure`	614.77	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Error`	614.80	test_vpc_redundant.py

blueorangutan · 2024-02-03T07:39:45Z

[SF] Trillian test result (tid-9044)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 76845 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8545-t9044-vmware-67u3.zip
Smoke tests completed. 108 look OK, 13 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_balanced_drs_algorithm	`Failure`	129.21	test_cluster_drs.py
test_08_upgrade_kubernetes_ha_cluster	`Failure`	1020.10	test_kubernetes_clusters.py
test_01_list_sec_storage_vm	`Failure`	0.05	test_ssvm.py
test_03_ssvm_internals	`Failure`	0.04	test_ssvm.py
test_05_stop_ssvm	`Failure`	0.04	test_ssvm.py
test_07_reboot_ssvm	`Failure`	0.04	test_ssvm.py
test_09_reboot_ssvm_forced	`Failure`	0.05	test_ssvm.py
test_11_destroy_ssvm	`Failure`	0.05	test_ssvm.py
ContextSuite context=TestVMWareStoragePolicies>:setup	`Error`	0.00	test_storage_policy.py
test_01_create_template	`Error`	1.15	test_templates.py
test_CreateTemplateWithDuplicateName	`Error`	88.58	test_templates.py
test_02_create_template_with_checksum_sha1	`Error`	65.64	test_templates.py
test_03_create_template_with_checksum_sha256	`Error`	65.68	test_templates.py
test_04_create_template_with_checksum_md5	`Error`	65.67	test_templates.py
test_05_create_template_with_no_checksum	`Error`	65.68	test_templates.py
ContextSuite context=TestTemplates>:setup	`Error`	138.15	test_templates.py
ContextSuite context=TestISOUsage>:setup	`Error`	0.00	test_usage.py
test_01_template_usage	`Error`	1.19	test_usage.py
test_01_volume_usage	`Error`	70.54	test_usage.py
ContextSuite context=TestVAppsVM>:setup	`Error`	1519.89	test_vm_life_cycle.py
test_10_attachAndDetach_iso	`Failure`	1513.47	test_vm_life_cycle.py
test_04_deploy_vnf_appliance	`Error`	311.83	test_vnf_templates.py
ContextSuite context=TestVolumes>:setup	`Error`	1517.06	test_volumes.py
ContextSuite context=TestIpv6Vpc>:setup	`Error`	0.00	test_vpc_ipv6.py
ContextSuite context=TestVPCRedundancy>:setup	`Error`	0.00	test_vpc_redundant.py
ContextSuite context=TestVPCNics>:setup	`Error`	0.00	test_vpc_router_nics.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup	`Error`	0.00	test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup	`Error`	0.00	test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup	`Error`	0.00	test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup	`Error`	0.00	test_vpc_vpn.py

…n' is kept after vm stop and not updated later)

…tate sync to proper state / host

…er state sync

vishesh92 · 2024-02-05T18:54:43Z

@blueorangutan package

blueorangutan · 2024-02-05T18:56:03Z

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-02-05T20:16:03Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8535

sureshanaparti · 2024-02-06T07:59:53Z

@blueorangutan test

vishesh92 · 2024-02-08T11:48:42Z

@blueorangutan test

blueorangutan · 2024-02-08T11:50:03Z

@vishesh92 a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2024-02-09T03:46:12Z

[SF] Trillian test result (tid-9130)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 55932 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8545-t9130-kvm-centos7.zip
Smoke tests completed. 118 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_delete_global_acl	`Failure`	2.48	test_global_acls.py
test_01_browser_migrate_template	`Error`	65.62	test_image_store_object_migration.py
test_02_trigger_shutdown	`Failure`	336.71	test_safe_shutdown.py
test_01_scale_up_verify	`Failure`	576.32	test_vm_autoscaling.py
test_03_scale_down_verify	`Failure`	308.64	test_vm_autoscaling.py
test_04_stop_remove_vm_in_vmgroup	`Failure`	2147.28	test_vm_autoscaling.py

kiranchavala

LGTM , Tested manually using the sql query with all hypervisors types kvm,vmware

mysql>update vm_instance set state="Stopped",host_id=null,last_host_id=1 where id=3;

Logs before the fix

2024-02-14 08:39:56,563 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (AgentManager-Handler-18:null) (logid:) Process host VM state report from ping process. host: 1
2024-02-14 08:39:56,568 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (AgentManager-Handler-18:null) (logid:) Process VM state report. host: 1, number of records in report: 4
2024-02-14 08:39:56,568 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (AgentManager-Handler-18:null) (logid:) VM state report. host: 1, vm id: 1, power state: PowerOn
2024-02-14 08:39:56,570 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (AgentManager-Handler-18:null) (logid:) VM state report. host: 1, vm id: 2, power state: PowerOn
2024-02-14 08:39:56,571 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (AgentManager-Handler-18:null) (logid:) VM state report. host: 1, vm id: 3, power state: PowerOn
2024-02-14 08:39:56,572 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (AgentManager-Handler-18:null) (logid:) VM state report. host: 1, vm id: 4, power state: PowerOn
2024-02-14 08:39:56,574 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (AgentManager-Handler-18:null) (logid:) Done with process of VM state report. host: 1
2024-02-14 08:40:56,567 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (AgentManager-Handler-13:null) (logid:) Process host VM state report from ping process. host: 1
2024-02-14 08:40:56,573 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (AgentManager-Handler-13:null) (logid:) Process VM state report. host: 1, number of records in report: 4
2024-02-14 08:40:56,573 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (AgentManager-Handler-13:null) (logid:) VM state report. host: 1, vm id: 1, power state: PowerOn
2024-02-14 08:40:56,574 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (AgentManager-Handler-13:null) (logid:) VM state report. host: 1, vm id: 2, power state: PowerOn
2024-02-14 08:40:56,576 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (AgentManager-Handler-13:null) (logid:) VM state report. host: 1, vm id: 3, power state: PowerOn
2024-02-14 08:40:56,578 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (AgentManager-Handler-13:null) (logid:) VM state report. host: 1, vm id: 4, power state: PowerOn
2024-02-14 08:40:56,580 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (AgentManager-Handler-13:null) (logid:) Done with process of VM state report. host: 1

Logs after fix


[root@ol8 ~]# tail -f /var/log/cloudstack/management/management-server.log  |grep -i "c.c.v.VirtualMachinePowerStateSyncImpl"
2024-02-14 08:43:37,084 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (AgentManager-Handler-4:null) (logid:) Process host VM state report from ping process. host: 2
2024-02-14 08:43:37,088 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (AgentManager-Handler-4:null) (logid:) Process VM state report. host: 2, number of records in report: 3
2024-02-14 08:43:37,088 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (AgentManager-Handler-4:null) (logid:) VM state report. host: 2, vm id: 1, power state: PowerOn
2024-02-14 08:43:37,089 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (AgentManager-Handler-4:null) (logid:) VM state report. host: 2, vm id: 2, power state: PowerOn
2024-02-14 08:43:37,090 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (AgentManager-Handler-4:null) (logid:) VM state report. host: 2, vm id: 3, power state: PowerOn
2024-02-14 08:43:37,092 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (AgentManager-Handler-4:null) (logid:) Done with process of VM state report. host: 2
2024-02-14 08:44:26,830 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (AgentManager-Handler-17:null) (logid:) Process host VM state report from ping process. host: 1
2024-02-14 08:44:26,832 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (AgentManager-Handler-17:null) (logid:) Process VM state report. host: 1, number of records in report: 1
2024-02-14 08:44:26,832 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (AgentManager-Handler-17:null) (logid:) VM state report. host: 1, vm id: 4, power state: PowerOn
2024-02-14 08:44:26,835 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (AgentManager-Handler-17:null) (logid:) Done with process of VM state report. host: 1
2024-02-14 08:44:37,059 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (AgentManager-Handler-2:null) (logid:) Process host VM state report from ping process. host: 2
2024-02-14 08:44:37,063 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (AgentManager-Handler-2:null) (logid:) Process VM state report. host: 2, number of records in report: 3
2024-02-14 08:44:37,063 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (AgentManager-Handler-2:null) (logid:) VM state report. host: 2, vm id: 1, power state: PowerOn
2024-02-14 08:44:37,064 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (AgentManager-Handler-2:null) (logid:) VM state report. host: 2, vm id: 2, power state: PowerOn
2024-02-14 08:44:37,066 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (AgentManager-Handler-2:null) (logid:) VM state report. host: 2, vm id: 3, power state: PowerOn
2024-02-14 08:44:37,070 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (AgentManager-Handler-2:null) (logid:) VM state report is updated. host: 2, vm id: 3, power state: PowerOn
2024-02-14 08:44:37,117 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (AgentManager-Handler-2:null) (logid:) Done with process of VM state report. host: 2

yadvr · 2024-02-15T05:21:33Z

Many smoketests are failing @vishesh92 @kiranchavala
@blueorangutan package

yadvr · 2024-02-15T05:22:05Z

@blueorangutan package

blueorangutan · 2024-02-15T05:24:03Z

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-02-15T06:24:43Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8659

vishesh92 · 2024-02-15T07:30:55Z

@blueorangutan test matrix

blueorangutan · 2024-02-15T07:32:03Z

@vishesh92 a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

DaanHoogland · 2024-02-15T09:53:37Z

engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java

                if (VirtualMachine.Type.User.equals(vm.type) && ResourceCountRunningVMsonly.value()) {
                    ServiceOfferingVO offering = _offeringDao.findById(vm.getId(), vm.getServiceOfferingId());
-                    resourceCountDecrement(vm.getAccountId(),new Long(offering.getCpu()), new Long(offering.getRamSize()));
+                    resourceCountDecrement(vm.getAccountId(), offering.getCpu().longValue(), offering.getRamSize().longValue());


in the database these fields are nullable. Are we sure these are not potential NPE´s?

The code below gets cpu/ram from user_vm_details if it is null in service offering.

ServiceOfferingVO offering = _offeringDao.findById(vm.getId(), vm.getServiceOfferingId());

As Wei said, it's handled in OfferingDao's findById.

cloudstack/engine/schema/src/main/java/com/cloud/service/dao/ServiceOfferingDaoImpl.java

Lines 171 to 182 in a31449b

public ServiceOfferingVO findById(Long vmId, long serviceOfferingId) {

ServiceOfferingVO offering = super.findById(serviceOfferingId);

if (offering.isDynamic()) {

offering.setDynamicFlag(true);

if (vmId == null) {

throw new CloudRuntimeException("missing argument vmId");

}

Map<String, String> dynamicOffering = userVmDetailsDao.listDetailsKeyPairs(vmId);

return getComputeOffering(offering, dynamicOffering);

}

return offering;

}

cloudstack/engine/schema/src/main/java/com/cloud/service/dao/ServiceOfferingDaoImpl.java

Lines 205 to 219 in a31449b

public ServiceOfferingVO getComputeOffering(ServiceOfferingVO serviceOffering, Map<String, String> customParameters) {

ServiceOfferingVO dummyoffering = new ServiceOfferingVO(serviceOffering);

dummyoffering.setDynamicFlag(true);

if (customParameters.containsKey(UsageEventVO.DynamicParameters.cpuNumber.name())) {

dummyoffering.setCpu(Integer.parseInt(customParameters.get(UsageEventVO.DynamicParameters.cpuNumber.name())));

}

if (customParameters.containsKey(UsageEventVO.DynamicParameters.cpuSpeed.name())) {

dummyoffering.setSpeed(Integer.parseInt(customParameters.get(UsageEventVO.DynamicParameters.cpuSpeed.name())));

}

if (customParameters.containsKey(UsageEventVO.DynamicParameters.memory.name())) {

dummyoffering.setRamSize(Integer.parseInt(customParameters.get(UsageEventVO.DynamicParameters.memory.name())));

}

return dummyoffering;

}

new Long(null) also throws a NPE. So, this is not really relevant to this PR but a minor code improvement.

yes, the method has been used in many places, it works well.
No need to add a null check I think.

anyway , good question @DaanHoogland

ok, guys, I agree i think, if we get an NPE a check would not help us take measure against it. decreasing by 0 (zero) does not make sense either.

Any improvement on this would be out of scope for this PR and I think it might not be high prio (just good to keep in mind)

yeah
A check can be added in the code Vishesh shared above.

For example

return validateOfferingParameters(offering)

blueorangutan · 2024-02-15T19:14:06Z

[SF] Trillian test result (tid-9217)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40686 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8545-t9217-xenserver-71.zip
Smoke tests completed. 129 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

blueorangutan · 2024-02-15T20:34:49Z

[SF] Trillian test result (tid-9219)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45409 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8545-t9219-kvm-centos7.zip
Smoke tests completed. 128 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_trigger_shutdown	`Failure`	336.75	test_safe_shutdown.py

blueorangutan · 2024-02-15T21:03:00Z

[SF] Trillian test result (tid-9218)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 47159 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8545-t9218-vmware-67u3.zip
Smoke tests completed. 129 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

DaanHoogland

clgtm

Co-authored-by: Suresh Kumar Anaparti <suresh.anaparti@shapeblue.com>

…ent NPE followup of discussion in apache#8545 (comment)

DaanHoogland reviewed Jan 23, 2024

View reviewed changes

engine/schema/src/main/java/com/cloud/vm/dao/VMInstanceDaoImpl.java Outdated Show resolved Hide resolved

DaanHoogland added this to the 4.19.1.0 milestone Jan 23, 2024

DaanHoogland added the component:orchestration label Jan 23, 2024

boring-cyborg bot added the component:compute label Feb 2, 2024

vishesh92 force-pushed the fixup-vm-powerstate-update branch from 87a543b to bb812aa Compare February 2, 2024 08:21

vishesh92 changed the base branch from main to 4.19 February 5, 2024 18:52

boring-cyborg bot added the component:kvm label Feb 5, 2024

vishesh92 and others added 6 commits February 6, 2024 00:22

Update VM's state if powerstate & state are not in sync

c9ef2a5

Add unit tests

2c383a6

some code improvements for instacne / power state check

3437f5c

Update power state after vm stop confirmation (as power state 'PowerO…

17ea9e7

…n' is kept after vm stop and not updated later)

Reset the power state update counter before migrate, to allow power s…

b3580ba

…tate sync to proper state / host

Do not consider transitional states (Starting, Stopping) to check pow…

007b0a8

…er state sync

vishesh92 force-pushed the fixup-vm-powerstate-update branch from bb812aa to 007b0a8 Compare February 5, 2024 18:53

set powerstate to off for all vm types

cc8bd7b

sureshanaparti requested a review from weizhouapache February 6, 2024 08:00

kiranchavala approved these changes Feb 15, 2024

View reviewed changes

yadvr marked this pull request as ready for review February 15, 2024 05:20

yadvr requested a review from harikrishna-patnala February 15, 2024 05:21

DaanHoogland reviewed Feb 15, 2024

View reviewed changes

DaanHoogland approved these changes Feb 16, 2024

View reviewed changes

DaanHoogland merged commit 1a11311 into apache:4.19 Feb 19, 2024

DaanHoogland deleted the fixup-vm-powerstate-update branch February 19, 2024 12:56

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Mar 5, 2024

Fixup vm powerstate update (apache#8545)

5120e40

Co-authored-by: Suresh Kumar Anaparti <suresh.anaparti@shapeblue.com>

weizhouapache added a commit to weizhouapache/cloudstack that referenced this pull request Dec 12, 2024

engine/schema: validate cpu/speed/ramsize of service offering to prev…

fcb7d0e

…ent NPE followup of discussion in apache#8545 (comment)

	public ServiceOfferingVO findById(Long vmId, long serviceOfferingId) {
	ServiceOfferingVO offering = super.findById(serviceOfferingId);
	if (offering.isDynamic()) {
	offering.setDynamicFlag(true);
	if (vmId == null) {
	throw new CloudRuntimeException("missing argument vmId");
	}
	Map<String, String> dynamicOffering = userVmDetailsDao.listDetailsKeyPairs(vmId);
	return getComputeOffering(offering, dynamicOffering);
	}
	return offering;
	}

	public ServiceOfferingVO getComputeOffering(ServiceOfferingVO serviceOffering, Map<String, String> customParameters) {
	ServiceOfferingVO dummyoffering = new ServiceOfferingVO(serviceOffering);
	dummyoffering.setDynamicFlag(true);
	if (customParameters.containsKey(UsageEventVO.DynamicParameters.cpuNumber.name())) {
	dummyoffering.setCpu(Integer.parseInt(customParameters.get(UsageEventVO.DynamicParameters.cpuNumber.name())));
	}
	if (customParameters.containsKey(UsageEventVO.DynamicParameters.cpuSpeed.name())) {
	dummyoffering.setSpeed(Integer.parseInt(customParameters.get(UsageEventVO.DynamicParameters.cpuSpeed.name())));
	}
	if (customParameters.containsKey(UsageEventVO.DynamicParameters.memory.name())) {
	dummyoffering.setRamSize(Integer.parseInt(customParameters.get(UsageEventVO.DynamicParameters.memory.name())));
	}

	return dummyoffering;
	}

Conversation

vishesh92 commented Jan 22, 2024 • edited by sureshanaparti Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

vishesh92 commented Jan 22, 2024

Uh oh!

blueorangutan commented Jan 22, 2024

Uh oh!

codecov bot commented Jan 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Jan 22, 2024

Uh oh!

vishesh92 commented Jan 22, 2024

Uh oh!

blueorangutan commented Jan 22, 2024

Uh oh!

Uh oh!

vishesh92 commented Feb 2, 2024

Uh oh!

blueorangutan commented Feb 2, 2024

Uh oh!

blueorangutan commented Feb 2, 2024

Uh oh!

sureshanaparti commented Feb 2, 2024

Uh oh!

blueorangutan commented Feb 2, 2024

Uh oh!

blueorangutan commented Feb 3, 2024

Uh oh!

blueorangutan commented Feb 3, 2024

Uh oh!

vishesh92 commented Feb 5, 2024

Uh oh!

blueorangutan commented Feb 5, 2024

Uh oh!

blueorangutan commented Feb 5, 2024

Uh oh!

sureshanaparti commented Feb 6, 2024

Uh oh!

vishesh92 commented Feb 8, 2024

Uh oh!

blueorangutan commented Feb 8, 2024

Uh oh!

blueorangutan commented Feb 9, 2024

Uh oh!

kiranchavala left a comment

Choose a reason for hiding this comment

Uh oh!

yadvr commented Feb 15, 2024

Uh oh!

yadvr commented Feb 15, 2024

Uh oh!

blueorangutan commented Feb 15, 2024

Uh oh!

blueorangutan commented Feb 15, 2024

Uh oh!

vishesh92 commented Feb 15, 2024

Uh oh!

blueorangutan commented Feb 15, 2024

Uh oh!

DaanHoogland Feb 15, 2024

Choose a reason for hiding this comment

Uh oh!

weizhouapache Feb 15, 2024

Choose a reason for hiding this comment

Uh oh!

vishesh92 Feb 16, 2024

Choose a reason for hiding this comment

Uh oh!

vishesh92 Feb 16, 2024

Choose a reason for hiding this comment

Uh oh!

vishesh92 commented Jan 22, 2024 •

edited by sureshanaparti

Loading

codecov bot commented Jan 22, 2024 •

edited

Loading