Skip to content

Veeam: revert unnecessary VM state change if restore backup and attach to another VM#8614

Merged
DaanHoogland merged 1 commit intoapache:4.19from
weizhouapache:4.19-fix-veeam-backup-attach
Feb 9, 2024
Merged

Veeam: revert unnecessary VM state change if restore backup and attach to another VM#8614
DaanHoogland merged 1 commit intoapache:4.19from
weizhouapache:4.19-fix-veeam-backup-attach

Conversation

@weizhouapache
Copy link
Member

Description

This PR reverts some changes in #7238

When restore backup of a VM and attach the volume to another VM, the original VM is not changed/touched, therefore the VM state should not be updated.

With this change, all the smoke tests for veeam (https://github.com/apache/cloudstack/blob/main/test/integration/smoke/test_backup_recovery_veeam.py) succeed.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

…o another VM

This PR reverts some changes in apache#7238

When restore backup of a VM and attach the volume to another VM, the original VM is not changed/touched, therefore the VM state should not be updated.
@weizhouapache weizhouapache requested a review from SadiJr February 6, 2024 10:05
@weizhouapache weizhouapache changed the title Veeam: revert unnecessary state change if restore backup and attach to another VM Veeam: revert unnecessary VM state change if restore backup and attach to another VM Feb 6, 2024
@weizhouapache
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c795547) 20.99% compared to head (f7d6393) 30.84%.
Report is 1 commits behind head on 4.19.

Additional details and impacted files
@@             Coverage Diff              @@
##               4.19    #8614      +/-   ##
============================================
+ Coverage     20.99%   30.84%   +9.84%     
- Complexity    19683    34083   +14400     
============================================
  Files          4849     5346     +497     
  Lines        324441   375417   +50976     
  Branches      45573    54598    +9025     
============================================
+ Hits          68121   115796   +47675     
+ Misses       246563   244325    -2238     
- Partials       9757    15296    +5539     
Flag Coverage Δ
simulator-marvin-tests 24.71% <ø> (+3.72%) ⬆️
uitests 4.39% <ø> (?)
unit-tests 16.54% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weizhouapache
Copy link
Member Author

@blueorangutan test rocky8 vmware-70u3

@blueorangutan
Copy link

@weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + vmware-70u3) has been kicked to run smoke tests

@weizhouapache
Copy link
Member Author

test results

Smoke tests completed. 120 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_balanced_drs_algorithm | `Failure` | 139.25 | test_cluster_drs.py
test_02_list_cpvm_vm | `Failure` | 0.04 | test_ssvm.py
test_04_cpvm_internals | `Failure` | 0.05 | test_ssvm.py

Copy link
Contributor

@SadiJr SadiJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLGTM

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland DaanHoogland merged commit a924a11 into apache:4.19 Feb 9, 2024
@DaanHoogland DaanHoogland deleted the 4.19-fix-veeam-backup-attach branch February 9, 2024 15:30
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Feb 20, 2024
@DaanHoogland DaanHoogland added this to the 4.19.1.0 milestone May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

4 participants