Veeam: revert unnecessary VM state change if restore backup and attach to another VM#8614
Merged
DaanHoogland merged 1 commit intoapache:4.19from Feb 9, 2024
Conversation
…o another VM This PR reverts some changes in apache#7238 When restore backup of a VM and attach the volume to another VM, the original VM is not changed/touched, therefore the VM state should not be updated.
Member
Author
|
@blueorangutan package |
|
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #8614 +/- ##
============================================
+ Coverage 20.99% 30.84% +9.84%
- Complexity 19683 34083 +14400
============================================
Files 4849 5346 +497
Lines 324441 375417 +50976
Branches 45573 54598 +9025
============================================
+ Hits 68121 115796 +47675
+ Misses 246563 244325 -2238
- Partials 9757 15296 +5539
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Member
Author
|
@blueorangutan test rocky8 vmware-70u3 |
|
@weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + vmware-70u3) has been kicked to run smoke tests |
Member
Author
|
test results |
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Feb 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR reverts some changes in #7238
When restore backup of a VM and attach the volume to another VM, the original VM is not changed/touched, therefore the VM state should not be updated.
With this change, all the smoke tests for veeam (https://github.com/apache/cloudstack/blob/main/test/integration/smoke/test_backup_recovery_veeam.py) succeed.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?