Skip to content

Polish UI instance schedule modal#8620

Merged
DaanHoogland merged 2 commits intoapache:4.19from
shapeblue:ui-instance-schedule
Feb 26, 2024
Merged

Polish UI instance schedule modal#8620
DaanHoogland merged 2 commits intoapache:4.19from
shapeblue:ui-instance-schedule

Conversation

@vishesh92
Copy link
Member

Description

This PR polishes the instance schedule modal.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

image

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@vishesh92 vishesh92 changed the base branch from main to 4.19 February 7, 2024 07:33
@vishesh92 vishesh92 force-pushed the ui-instance-schedule branch from 85df23e to da7d88f Compare February 7, 2024 07:34
@codecov
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (df412a9) 30.48% compared to head (4314947) 30.50%.
Report is 30 commits behind head on 4.19.

Files Patch % Lines
ui/src/views/compute/InstanceSchedules.vue 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               4.19    #8620      +/-   ##
============================================
+ Coverage     30.48%   30.50%   +0.01%     
- Complexity    33710    33756      +46     
============================================
  Files          5346     5347       +1     
  Lines        375421   375625     +204     
  Branches      54598    54627      +29     
============================================
+ Hits         114460   114571     +111     
- Misses       245823   245914      +91     
- Partials      15138    15140       +2     
Flag Coverage Δ
simulator-marvin-tests 24.25% <ø> (+<0.01%) ⬆️
uitests 4.39% <0.00%> (-0.01%) ⬇️
unit-tests 16.57% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vishesh92 vishesh92 marked this pull request as ready for review February 12, 2024 19:27
@yadvr yadvr requested a review from DaanHoogland February 16, 2024 05:52
@yadvr yadvr added this to the 4.19.1.0 milestone Feb 16, 2024
@DaanHoogland
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8620 (QA-JID-285)

@DaanHoogland
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8689

@DaanHoogland
Copy link
Contributor

@blueorangutan test alma9 kvm-alma9 keepEnv

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-9265)
Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9
Total time taken: 53563 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8620-t9265-kvm-alma9.zip
Smoke tests completed. 129 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

Copy link
Member

@kiranchavala kiranchavala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vishesh92
Could you please add some more spaces above cron mode

the text is overlapping

Screenshot 2024-02-20 at 12 33 47 PM

@vishesh92
Copy link
Member Author

@vishesh92 Could you please add some more spaces above cron mode

the text is overlapping

@kiranchavala I have fixed the issue. Please check now.

@vishesh92
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@vishesh92
Copy link
Member Author

@blueorangutan ui

@blueorangutan
Copy link

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build failed: ✖️
(SL-JID-286)

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8722

Copy link
Member

@kiranchavala kiranchavala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , there is proper space now

Screenshot 2024-02-26 at 4 03 23 PM

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland DaanHoogland merged commit 08dc1bb into apache:4.19 Feb 26, 2024
@DaanHoogland DaanHoogland deleted the ui-instance-schedule branch February 26, 2024 13:40
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

5 participants