Migrate tests to JUnit5 #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use JUnit5 annotations * use JUnit5 Assertions and Assumptions * remove public visibility from tests * remove junit-vintage-engine dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In c05870d @garydgregory already began the transition towards JUnit5. This PR aims to finish that.
The main points and changes are
AssertionsandAssumptionspublicvisibility from tests classes and methods (best-practise)junit-vintage-enginedependency as it is no longer requiredI validated that all tests succeeded before and after my changes and the overall number of tests did not change. Test coverage is also identical.
There are some oddly formatted classes - I tried my very best to keep the original formatting intact to minimize the changeset.