feat: Add nested Array literal support #2181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2181 +/- ##
============================================
+ Coverage 56.12% 57.53% +1.40%
- Complexity 976 1295 +319
============================================
Files 119 147 +28
Lines 11743 13477 +1734
Branches 2251 2354 +103
============================================
+ Hits 6591 7754 +1163
- Misses 4012 4457 +445
- Partials 1140 1266 +126 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andygrove
reviewed
Sep 3, 2025
| // can be tracked https://github.com/apache/datafusion-comet/issues/1937 | ||
| // now supports only Array of primitive | ||
| (Seq(CometConf.SCAN_NATIVE_ICEBERG_COMPAT, CometConf.SCAN_NATIVE_DATAFUSION) | ||
| .contains(CometConf.COMET_NATIVE_SCAN_IMPL.get()) && dataType |
There was a problem hiding this comment.
CometConf.COMET_NATIVE_SCAN_IMPL.get() returns auto by default, so this logic would not get triggered in the default case?
There was a problem hiding this comment.
Thats a good point, for auto is it a way to figure out current scan impl?
There was a problem hiding this comment.
I think there is no way to know it in runtime, created PR #2295
andygrove
reviewed
Sep 3, 2025
| """ | ||
| |select 1 a | ||
| |""".stripMargin, | ||
| "select array(array(1, 2, null), array(), array(10), null) from tbl") |
|
Test failed because of #2321 |
|
Depends on #2286 |
|
@andygrove PTAL again. all tests passed including #2321 |
andygrove
approved these changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2157
.
Rationale for this change
What changes are included in this PR?
This update introduces support for nested ARRAY literals in the Comet query plan serialization logic. The changes include both code refactoring and enhanced test coverage.
Highlights
Nested ARRAY Literal Support:
The code now handles array literals containing other arrays (i.e., arrays of arrays), enabling use of multi-dimensional array literals in queries.
Refactored Serialization Logic:
Serialization of array literals (including primitive and nested arrays) is now handled by a new recursive helper function, makeListLiteral.
The logic for handling array types has been extracted from a large match-case block into this helper, improving maintainability and extensibility.
Improved Type Handling:
The logic now recognizes and correctly serializes arrays whose element type is itself an array.
Type checks and element conversions are clarified and improved.
Detailed Changes
Code (QueryPlanSerde.scala)