Add identifier unicode support in Mysql, Postgres and Redshift #1933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iffyio
reviewed
Jul 11, 2025
There was a problem hiding this comment.
Thanks @etgarperets, could you also take a look at the ci failure (and also to merge in latest from main as there are currently some conflicts on the branch)
tests/sqlparser_common.rs
Outdated
Comment on lines
15901
to
16140
| let unicode_sql = r#"SELECT phoneǤЖשचᎯ⻩☯♜🦄⚛🀄ᚠ⌛🌀 tbl FROM customers"#; | ||
| let dialects_supporting_unicode = TestedDialects::new(vec![Box::new(MySqlDialect {}), Box::new(RedshiftSqlDialect {}), Box::new(PostgreSqlDialect {})]); | ||
| let _ = dialects_supporting_unicode.parse_sql_statements(unicode_sql).unwrap(); |
There was a problem hiding this comment.
Suggested change
| let unicode_sql = r#"SELECT phoneǤЖשचᎯ⻩☯♜🦄⚛🀄ᚠ⌛🌀 tbl FROM customers"#; | |
| let dialects_supporting_unicode = TestedDialects::new(vec![Box::new(MySqlDialect {}), Box::new(RedshiftSqlDialect {}), Box::new(PostgreSqlDialect {})]); | |
| let _ = dialects_supporting_unicode.parse_sql_statements(unicode_sql).unwrap(); | |
| let sql = r#"SELECT phoneǤЖשचᎯ⻩☯♜🦄⚛🀄ᚠ⌛🌀 tbl FROM customers"#; | |
| let dialects = TestedDialects::new(vec![Box::new(MySqlDialect {}), Box::new(RedshiftSqlDialect {}), Box::new(PostgreSqlDialect {})]); | |
| let _ = dialects.verified_stmt(unicode_sql); |
tests/sqlparser_common.rs
Outdated
| @@ -15895,3 +15895,11 @@ fn parse_create_procedure_with_parameter_modes() { | |||
| _ => unreachable!(), | |||
| } | |||
| } | |||
|
|
|||
| #[test] | |||
| fn test_unicode_support() { | |||
There was a problem hiding this comment.
Suggested change
| fn test_unicode_support() { | |
| fn test_identifier_unicode_support() { |
src/dialect/mysql.rs
Outdated
| @@ -51,7 +51,7 @@ impl Dialect for MySqlDialect { | |||
| } | |||
|
|
|||
| fn is_identifier_part(&self, ch: char) -> bool { | |||
| self.is_identifier_start(ch) || ch.is_ascii_digit() | |||
| self.is_identifier_start(ch) || ch.is_ascii_digit() || !ch.is_ascii() | |||
There was a problem hiding this comment.
Can we add a comment to these highlighting that they implement unicode character support?
iffyio
changed the title
…o added a test for that
etgarperets
force-pushed
the
unicode_support
branch
from
bdd6f57 to
c03a7d7
Compare
iffyio
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…o added a test for that