feat: Add RESET to the base dialect #2078 #2079
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iffyio
reviewed
Oct 30, 2025
src/dialect/mod.rs
Outdated
Comment on lines
1210
to
1220
|
|
||
| /// Returns true if the dialect supports the `RESET` statement | ||
| /// for resetting session variables. | ||
| /// | ||
| /// ```sql | ||
| /// RESET configuration_parameter; | ||
| /// RESET ALL; | ||
| /// ``` | ||
| fn supports_reset(&self) -> bool { | ||
| false | ||
| } |
There was a problem hiding this comment.
Suggested change
| /// Returns true if the dialect supports the `RESET` statement | |
| /// for resetting session variables. | |
| /// | |
| /// ```sql | |
| /// RESET configuration_parameter; | |
| /// RESET ALL; | |
| /// ``` | |
| fn supports_reset(&self) -> bool { | |
| false | |
| } |
I think we can let the parser always accept the statement if it shows up, without considering the dialect
There was a problem hiding this comment.
Can do. I think out of the list of dialects only ANSI, sqlite, and Hive lack support (Hive SQL doesn't take a parameter).
There was a problem hiding this comment.
I updated the ticket to include exactly which dialects support RESET, and its a bit touch and go. Right now this seems reasonable (in that it accepts a very reasonable use, though not strictly correct for all dialects).
watford-ep
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the RESET statement to the base dialect.