Skip to content

Conversation

@mvzink
Copy link
Contributor

@mvzink mvzink commented Jan 7, 2026

According to the docs, MySQL supports << and >> operators. They are currently named PGBitwiseShiftLeft and PGBitwiseShiftRight, respectively, so the name is a bit misleading, but doesn't see worth changing at the moment.

According to the [docs], MySQL supports `<<` and `>>` operators. They
are currently named `PGBitwiseShiftLeft` and `PGBitwiseShiftRight`,
respectively, so the name is a bit misleading, but doesn't see worth
changing at the moment.

[docs]: https://dev.mysql.com/doc/refman/8.4/en/bit-functions.html
To remove another hardcoded `dialect_is!` list.
Copy link
Contributor

@yoavcloud yoavcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nicely done @mvzink!

FYI @iffyio

@yoavcloud yoavcloud added this pull request to the merge queue Jan 8, 2026
Merged via the queue into apache:main with commit 3af9988 Jan 8, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants