Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test for datafusion #14824 #7

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Update test for datafusion #14824 #7

merged 2 commits into from
Feb 26, 2025
+10,744 −10,744

Conversation

jayzhan211
Copy link
Contributor

@jayzhan211 jayzhan211 commented Feb 26, 2025 •
edited
Loading

@jayzhan211 jayzhan211 marked this pull request as ready for review February 26, 2025 08:02
@jayzhan211 jayzhan211 mentioned this pull request Feb 26, 2025
Open
alamb
alamb approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I clearly couldn't review 100k lines of changes, but the error message changes make sense to me so I say let's do it!

@alamb alamb merged commit 3462eaa into apache:main Feb 26, 2025
@alamb
Copy link
Contributor

alamb commented Feb 26, 2025

Thanks @jayzhan211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jayzhan211 @alamb