Skip to content

Workaround verification script error for branch-46 #14983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Workaround verification script error for branch-46 #14983

wants to merge 2 commits into from

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Mar 3, 2025 •
edited
Loading

Which issue does this PR close?

Rationale for this change

I am not sure why but the verification script started failing (see #14982)

Could also be related to

What changes are included in this PR?

Remove rust toolchain toml override file

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added documentation Improvements or additions to documentation sql SQL Planner development-process Related to development process of DataFusion logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates optimizer Optimizer rules core Core DataFusion crate substrait Changes to the substrait crate proto Related to proto crate functions Changes to functions implementation labels Mar 3, 2025
@alamb alamb force-pushed the alamb/fix_verification branch from ae89569 to a18c7d1 Compare March 3, 2025 16:18
@github-actions github-actions bot removed documentation Improvements or additions to documentation sql SQL Planner logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates optimizer Optimizer rules core Core DataFusion crate substrait Changes to the substrait crate proto Related to proto crate functions Changes to functions implementation labels Mar 3, 2025
@alamb alamb changed the title Alamb/fix verification Fix verification script for branch-46 Mar 3, 2025
@alamb alamb marked this pull request as ready for review March 3, 2025 16:23
@alamb alamb changed the title Fix verification script for branch-46 Workaround verification script error for branch-46 Mar 3, 2025
@andygrove
Copy link
Member

I run into the same issue when using 46.0.0-rc1 in Comet, and this PR will not help with that.

@andygrove
Copy link
Member

I run into the same issue when using 46.0.0-rc1 in Comet, and this PR will not help with that.

I may need to update Comet's toolchain file to match. I will try that next.

@alamb
Copy link
Contributor Author

alamb commented Mar 3, 2025

I run into the same issue when using 46.0.0-rc1 in Comet, and this PR will not help with that.

I may need to update Comet's toolchain file to match. I will try that next.

I think there is something that broke with rustup:

We also hit the issue with CI as well

@alamb
Copy link
Contributor Author

alamb commented Mar 3, 2025

have a better plan

@alamb alamb closed this Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
development-process Related to development process of DataFusion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alamb @andygrove