-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default EXPLAIN
format in datafusion-cli
to tree
format
#15427
Conversation
@@ -74,6 +75,31 @@ fn cli_quick_test<'a>( | |||
assert_cmd_snapshot!(cmd); | |||
} | |||
|
|||
#[rstest] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not get these to work as additional examples in quick_test
for reasons I couldn't figure out. So I just made a new test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, pulled into this branch
c7ced76
to
cfa9171
Compare
EXPLAIN
format in datafusion-cli
to tree
format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking forward to df47 😆
this is a good call -- I will fix that |
Run extended tests |
Run extended tests |
I pushed a fix and a test for this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍
I'll plan to merge this one tomorrow unless anyone else would like time to comment |
🚀 📖 THanks again @blaginin and @xudong963 |
Which issue does this PR close?
tree
explain by default #15343Rationale for this change
We have nice explain plans, let's default DataFusion cli to use them
What changes are included in this PR?
Note that as discussed on #15343, this ONLY affects datafusion-cli. Any downstream project that wants nicer explain plans by default can adjust the configuration settings
Are these changes tested?
Yes with new tests
Are there any user-facing changes?
EXPLAIN
in datafusion-cli will now use the new explain tree format. For example:You can get the previous indent explain plan by asking for it explicitly: