Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) Upgrading to arrow 55 #15466

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Mar 27, 2025

I want to be able to test stuff from arrow-rs (specifically filter pushdown) using datafusion benchmarks, so the first step to get main going

This will also be a step testing how the upgrade will go

Some benchmark results show performance is as good or better (I will review why shortly)

Details

--------------------
Benchmark clickbench_extended.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Query        ┃  main_base ┃ alamb_test_upgrade_54 ┃    Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ QQuery 0     │  1971.67ms │             1877.73ms │ no change │
│ QQuery 1     │   771.26ms │              763.66ms │ no change │
│ QQuery 2     │  1494.09ms │             1485.84ms │ no change │
│ QQuery 3     │   705.55ms │              701.31ms │ no change │
│ QQuery 4     │  1487.63ms │             1471.70ms │ no change │
│ QQuery 5     │ 16992.75ms │            17021.28ms │ no change │
└──────────────┴────────────┴───────────────────────┴───────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary                    ┃            ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (main_base)               │ 23422.94ms │
│ Total Time (alamb_test_upgrade_54)   │ 23321.52ms │
│ Average Time (main_base)             │  3903.82ms │
│ Average Time (alamb_test_upgrade_54) │  3886.92ms │
│ Queries Faster                       │          0 │
│ Queries Slower                       │          0 │
│ Queries with No Change               │          6 │
└──────────────────────────────────────┴────────────┘
--------------------
Benchmark clickbench_partitioned.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query        ┃  main_base ┃ alamb_test_upgrade_54 ┃        Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 0     │     2.32ms │                2.34ms │     no change │
│ QQuery 1     │    41.17ms │               39.30ms │     no change │
│ QQuery 2     │    96.51ms │               93.48ms │     no change │
│ QQuery 3     │   103.60ms │              100.78ms │     no change │
│ QQuery 4     │   940.21ms │              828.25ms │ +1.14x faster │
│ QQuery 5     │   934.81ms │              892.51ms │     no change │
│ QQuery 6     │    34.10ms │               38.36ms │  1.12x slower │
│ QQuery 7     │    45.50ms │               44.47ms │     no change │
│ QQuery 8     │   982.78ms │              951.60ms │     no change │
│ QQuery 9     │  1249.81ms │             1220.48ms │     no change │
│ QQuery 10    │   276.30ms │              268.93ms │     no change │
│ QQuery 11    │   313.00ms │              311.56ms │     no change │
│ QQuery 12    │   962.13ms │              963.96ms │     no change │
│ QQuery 13    │  1447.96ms │             1352.70ms │ +1.07x faster │
│ QQuery 14    │   873.13ms │              869.29ms │     no change │
│ QQuery 15    │  1071.00ms │             1083.64ms │     no change │
│ QQuery 16    │  1833.86ms │             1800.94ms │     no change │
│ QQuery 17    │  1676.93ms │             1656.01ms │     no change │
│ QQuery 18    │  3192.63ms │             3139.34ms │     no change │
│ QQuery 19    │    87.96ms │               86.12ms │     no change │
│ QQuery 20    │  1138.33ms │             1150.60ms │     no change │
│ QQuery 21    │  1353.32ms │             1385.28ms │     no change │
│ QQuery 22    │  2486.19ms │             2481.55ms │     no change │
│ QQuery 23    │  8587.32ms │             8551.42ms │     no change │
│ QQuery 24    │   495.70ms │              478.84ms │     no change │
│ QQuery 25    │   397.97ms │              398.90ms │     no change │
│ QQuery 26    │   541.95ms │              553.88ms │     no change │
│ QQuery 27    │  1673.79ms │             1698.70ms │     no change │
│ QQuery 28    │ 13031.86ms │            12686.98ms │     no change │
│ QQuery 29    │   539.10ms │              526.23ms │     no change │
│ QQuery 30    │   855.85ms │              865.06ms │     no change │
│ QQuery 31    │   894.35ms │              914.02ms │     no change │
│ QQuery 32    │  2855.15ms │             2717.30ms │     no change │
│ QQuery 33    │  3436.43ms │             3401.39ms │     no change │
│ QQuery 34    │  3449.45ms │             3441.70ms │     no change │
│ QQuery 35    │  1307.40ms │             1336.16ms │     no change │
│ QQuery 36    │   211.89ms │              228.86ms │  1.08x slower │
│ QQuery 37    │    93.25ms │               92.78ms │     no change │
│ QQuery 38    │   128.15ms │              131.08ms │     no change │
│ QQuery 39    │   405.49ms │              414.00ms │     no change │
│ QQuery 40    │    50.69ms │               52.99ms │     no change │
│ QQuery 41    │    45.75ms │               46.47ms │     no change │
│ QQuery 42    │    56.55ms │               56.26ms │     no change │
└──────────────┴────────────┴───────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary                    ┃            ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (main_base)               │ 60201.65ms │
│ Total Time (alamb_test_upgrade_54)   │ 59354.51ms │
│ Average Time (main_base)             │  1400.04ms │
│ Average Time (alamb_test_upgrade_54) │  1380.34ms │
│ Queries Faster                       │          2 │
│ Queries Slower                       │          2 │
│ Queries with No Change               │         39 │
└──────────────────────────────────────┴────────────┘
--------------------
Benchmark tpch_mem_sf1.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query        ┃ main_base ┃ alamb_test_upgrade_54 ┃        Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 1     │  125.53ms │              121.10ms │     no change │
│ QQuery 2     │   24.38ms │               24.28ms │     no change │
│ QQuery 3     │   35.13ms │               35.60ms │     no change │
│ QQuery 4     │   20.75ms │               21.03ms │     no change │
│ QQuery 5     │   58.41ms │               57.16ms │     no change │
│ QQuery 6     │    8.23ms │                7.99ms │     no change │
│ QQuery 7     │  104.37ms │              101.91ms │     no change │
│ QQuery 8     │   26.91ms │               27.37ms │     no change │
│ QQuery 9     │   64.46ms │               64.16ms │     no change │
│ QQuery 10    │   60.26ms │               58.95ms │     no change │
│ QQuery 11    │   13.08ms │               12.97ms │     no change │
│ QQuery 12    │   38.46ms │               38.48ms │     no change │
│ QQuery 13    │   30.71ms │               30.01ms │     no change │
│ QQuery 14    │   10.48ms │                9.78ms │ +1.07x faster │
│ QQuery 15    │   24.85ms │               24.91ms │     no change │
│ QQuery 16    │   24.42ms │               23.31ms │     no change │
│ QQuery 17    │   97.22ms │               96.90ms │     no change │
│ QQuery 18    │  252.46ms │              240.81ms │     no change │
│ QQuery 19    │   30.72ms │               27.80ms │ +1.11x faster │
│ QQuery 20    │   40.57ms │               40.75ms │     no change │
│ QQuery 21    │  173.70ms │              173.59ms │     no change │
│ QQuery 22    │   16.07ms │               16.87ms │     no change │
└──────────────┴───────────┴───────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Benchmark Summary                    ┃           ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ Total Time (main_base)               │ 1281.20ms │
│ Total Time (alamb_test_upgrade_54)   │ 1255.74ms │
│ Average Time (main_base)             │   58.24ms │
│ Average Time (alamb_test_upgrade_54) │   57.08ms │
│ Queries Faster                       │         2 │
│ Queries Slower                       │         0 │
│ Queries with No Change               │        20 │
└──────────────────────────────────────┴───────────┘

@github-actions github-actions bot added the common Related to common crate label Mar 28, 2025
@github-actions github-actions bot added the functions Changes to functions implementation label Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Related to common crate functions Changes to functions implementation sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant