Introduce avg_distinct() and sum_distinct() functions to DataFrame API
#17536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Jefffrey
commented
Sep 12, 2025
Comment on lines
+65
to
+74
| pub fn avg_distinct(expr: Expr) -> Expr { | ||
| Expr::AggregateFunction(datafusion_expr::expr::AggregateFunction::new_udf( | ||
| avg_udaf(), | ||
| vec![expr], | ||
| true, | ||
| None, | ||
| vec![], | ||
| None, | ||
| )) | ||
| } |
There was a problem hiding this comment.
Same as how count handles it:
datafusion/datafusion/functions-aggregate/src/count.rs
Lines 71 to 80 in bfc5067
Comment on lines
+504
to
+511
| min(col("c4")).alias("min(c4)"), | ||
| max(col("c4")).alias("max(c4)"), | ||
| avg(col("c4")).alias("avg(c4)"), | ||
| avg_distinct(col("c4")).alias("avg_distinct(c4)"), | ||
| sum(col("c4")).alias("sum(c4)"), | ||
| sum_distinct(col("c4")).alias("sum_distinct(c4)"), | ||
| count(col("c4")).alias("count(c4)"), | ||
| count_distinct(col("c4")).alias("count_distinct(c4)"), |
There was a problem hiding this comment.
I switched to c4 from c12 as c12 had some precision variations for avg_distinct leading to inconsistent test results, and figured it was easier to switch columns than slap round on the outputs
|
I think these new functions should be added to the default list in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
sum_distinct()function to dataframe #2407avg_distinct()function to dataframe #2409Rationale for this change
So we can use these distinct aggregates via DataFrames
What changes are included in this PR?
Introduce
avg_distinct()andsum_distinct()functions to be used in DataFrame API.Are these changes tested?
Added DataFrame tests, also proto roundtrip test.
Are there any user-facing changes?
New functions, updated documentation for DataFrame functions.