feat(spark): implement Spark make_dt_interval function
#17728
+608
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidlghellin
commented
Sep 23, 2025
datafusion/sqllogictest/test_files/spark/datetime/make_dt_interval.slt
Outdated
Show resolved
Hide resolved
datafusion/sqllogictest/test_files/spark/datetime/make_dt_interval.slt
Outdated
Show resolved
Hide resolved
Jefffrey
reviewed
Sep 24, 2025
| } | ||
|
|
||
| fn return_type(&self, _arg_types: &[DataType]) -> Result<DataType> { | ||
| Ok(DataType::Duration(Microsecond)) |
There was a problem hiding this comment.
This should be an interval instead right?
There was a problem hiding this comment.
There was a problem hiding this comment.
Can we include a comment here with this explanation for future reference?
datafusion/sqllogictest/test_files/spark/datetime/make_dt_interval.slt
Outdated
Show resolved
Hide resolved
datafusion/sqllogictest/test_files/spark/datetime/make_dt_interval.slt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
part of #15914
Rationale for this change
Migrate spark functions from https://github.com/lakehq/sail/ to datafusion engine to unify codebase
What changes are included in this PR?
implement spark udf make_interval
https://spark.apache.org/docs/latest/api/sql/index.html#make_dt_interval
Are these changes tested?
unit-tests and sqllogictests added
Are there any user-facing changes?
now can be called in queries