Refactor spark bit_get() signature away from user defined
#18836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jefffrey
commented
Nov 20, 2025
| pub fn new() -> Self { | ||
| Self { | ||
| signature: Signature::user_defined(Volatility::Immutable), | ||
| signature: Signature::coercible( |
Contributor
Author
There was a problem hiding this comment.
Signature change here
| ) | ||
| } | ||
| }?; | ||
| fn spark_bit_get(args: &[ArrayRef]) -> Result<ArrayRef> { |
Contributor
Author
There was a problem hiding this comment.
This function I made private, and also did a few refactors to make it more compact.
| } | ||
|
|
||
| #[cfg(test)] | ||
| mod tests { |
Contributor
Author
There was a problem hiding this comment.
These tests were duplicated by the SLTs so removed them
martin-g
reviewed
Nov 20, 2025
| }?; | ||
| fn spark_bit_get(args: &[ArrayRef]) -> Result<ArrayRef> { | ||
| let [value, position] = take_function_args("bit_get", args)?; | ||
| let pos_arg = position.as_primitive::<Int32Type>(); |
Member
There was a problem hiding this comment.
Is this safe to be done ?
From the other PR few days ago we know that position could be Null here.
Suggested change
| let pos_arg = position.as_primitive::<Int32Type>(); | |
| let pos_arg = position.as_primitive_opt::<Int32Type>() | |
| + .ok_or_else(|| internal_err!("Expected Int32 for position argument"))?; |
Contributor
Author
There was a problem hiding this comment.
It's safe, since we use Coercion::new_implicit then null types are casted to the target type (Int8). Also have an SLT test to verify this behaviour.
martin-g
approved these changes
Nov 21, 2025
alamb
changed the title
bit_get() signature away from user definedbit_get() signature away from user defined
alamb
approved these changes
Nov 21, 2025
| fn spark_bit_get(args: &[ArrayRef]) -> Result<ArrayRef> { | ||
| let [value, position] = take_function_args("bit_get", args)?; | ||
| let pos_arg = position.as_primitive::<Int32Type>(); | ||
| let ret = downcast_integer_array!( |
logan-keede
pushed a commit
to logan-keede/datafusion
that referenced
this pull request
Nov 23, 2025
…8836) ## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes apache#123` indicates that this PR will close issue apache#123. --> Part of apache#12725 ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> Prefer to avoid user_defined for consistency in function definitions. ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> Refactor signature of bit_get away from user_defined. Various other refactors. ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> Existing tests. ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> There's a public function I made private but I don't think it was ever intended to be public.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #12725
Rationale for this change
Prefer to avoid user_defined for consistency in function definitions.
What changes are included in this PR?
Refactor signature of bit_get away from user_defined.
Various other refactors.
Are these changes tested?
Existing tests.
Are there any user-facing changes?
There's a public function I made private but I don't think it was ever intended to be public.