Skip to content

Conversation

@getChan
Copy link
Contributor

@getChan getChan commented Dec 31, 2025

Which issue does this PR close?

  • Closes #.

Rationale for this change

benchmark

factorial_array         time:   [778.63 ns 783.03 ns 787.52 ns]
                        change: [−90.314% −90.211% −90.055%] (p = 0.00 < 0.05)
                        Performance has improved.

factorial_scalar        time:   [317.32 ns 319.36 ns 321.41 ns]
                        change: [−28.219% −27.508% −26.683%] (p = 0.00 < 0.05)
                        Performance has improved.

What changes are included in this PR?

  1. factorial implementation from using loop to looking up precomputed values.
  2. using the try_unary kernel function on PrimitiveArray. (However, since this isn’t unary function, it does not get vectorized execution)

and add benchmark

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@github-actions github-actions bot added the functions Changes to functions implementation label Dec 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

functions Changes to functions implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant