Skip to content

Enforce clippy::allow_attributes globally across workspace #19576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Jefffrey wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Enforce clippy::allow_attributes globally across workspace #19576

Jefffrey wants to merge 6 commits into from
+29 −112

Conversation

@Jefffrey
Copy link
Contributor

@Jefffrey Jefffrey commented Dec 31, 2025

Which issue does this PR close?

Rationale for this change

See issue.

What changes are included in this PR?

Fix up dangling allows that weren't covered in previous PRs, remove the per crate disables, and enable the warning at the workspace level.

Are these changes tested?

Linting.

Are there any user-facing changes?

No.

@github-actions github-actions bot added sql SQL Planner logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates optimizer Optimizer rules core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) substrait Changes to the substrait crate catalog Related to the catalog crate common Related to common crate execution Related to the execution crate proto Related to proto crate functions Changes to functions implementation datasource Changes to the datasource crate ffi Changes to the ffi crate physical-plan Changes to the physical-plan crate spark labels Dec 31, 2025
@Jefffrey Jefffrey mentioned this pull request Dec 31, 2025
Open
38 tasks
@Jefffrey Jefffrey marked this pull request as ready for review December 31, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

catalog Related to the catalog crate common Related to common crate core Core DataFusion crate datasource Changes to the datasource crate execution Related to the execution crate ffi Changes to the ffi crate functions Changes to functions implementation logical-expr Logical plan and expressions optimizer Optimizer rules physical-expr Changes to the physical-expr crates physical-plan Changes to the physical-plan crate proto Related to proto crate spark sql SQL Planner sqllogictest SQL Logic Tests (.slt) substrait Changes to the substrait crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

New lint clippy::allow_attributes

1 participant

@Jefffrey