perf: Improve performance of hex encoding in spark functions #19586
+21
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
approved these changes
Jan 1, 2026
Member
andygrove
left a comment
andygrove
left a comment
There was a problem hiding this comment.
LGTM. Thanks @ShashidharM0118.
Contributor
|
Have you benchmarked it? I’m curious about the performance impact. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
"{b:02x}"to hex-encode bytes #19569Rationale for this change
Completes the hex encoding optimization work from #19568 by replacing
write!format strings with lookup tables in the remaining instances (hexandsha1functions in spark module).What changes are included in this PR?
Avoid using
write!with a format string and use a more efficient approachAre these changes tested?
Yes
Are there any user-facing changes?
No.