[Improvement-18151] Simplify the code with lombok annotations#18174
[Improvement-18151] Simplify the code with lombok annotations#18174njnu-seafish wants to merge 15 commits intoapache:devfrom
Conversation
njnu-seafish
requested review from
Gallardot,
SbloodyS,
caishunfeng and
ruanwenjun
as code owners
ruanwenjun
left a comment
ruanwenjun
left a comment
There was a problem hiding this comment.
Please do not modify non-POJO objects
|
|
||
| @ToString | ||
| @Slf4j | ||
| @Data |
There was a problem hiding this comment.
Not all field should exposed to out layer, e.g latch, don't change the code you are not clear.
| public void setDepList(List<Long> depList) { | ||
| if (depList != null) { | ||
| this.depList = depList; | ||
| this.preTasks = JSONUtils.toJsonString(depList); | ||
| } | ||
| } |
There was a problem hiding this comment.
The project compiles successfully, and this method is unused.
| @Data | ||
| @Accessors(chain = true) |
There was a problem hiding this comment.
| @Data | |
| @Accessors(chain = true) | |
| @Accessors(chain = true) |
Why add this?
There was a problem hiding this comment.
Why add this?
Here is the code before refactoring：
public ParamsProps setPlaceholder(String placeholder) {
this.placeholder = placeholder;
return this;
}
Yes, this is not used.
There was a problem hiding this comment.
Why add this?
ok, revert those changes
| @Accessors(chain = true) | ||
| public class ParamsProps { | ||
|
|
||
| @JsonProperty("placeholder") |
There was a problem hiding this comment.
Why add this?
Here is the code before refactoring：
public ParamsProps setPlaceholder(String placeholder) {
this.placeholder = placeholder;
return this;
}
Yes, this is not used.
There was a problem hiding this comment.
Why add this?
ok， revert those changes
ruanwenjun
force-pushed
the
Improvement-18151-suyc
branch
from
604ccf3 to
ab497fe
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| import lombok.Data; | ||
| import lombok.EqualsAndHashCode; | ||
|
|
||
| @EqualsAndHashCode(callSuper = true) |
| import lombok.Data; | ||
| import lombok.EqualsAndHashCode; | ||
|
|
||
| @EqualsAndHashCode(callSuper = true) |
| import lombok.Data; | ||
| import lombok.EqualsAndHashCode; | ||
|
|
||
| @EqualsAndHashCode(callSuper = true) |
| import lombok.Data; | ||
| import lombok.EqualsAndHashCode; | ||
|
|
||
| @EqualsAndHashCode(callSuper = true) |
| import lombok.Data; | ||
| import lombok.EqualsAndHashCode; | ||
|
|
||
| @EqualsAndHashCode(callSuper = true) |
…hinscheduler into Improvement-18151-suyc
|
Reverted some unnecessary changes. Please take another look. Thanks! @ruanwenjun @SbloodyS |
|
CI failed. @njnu-seafish |
It's strange, here is the error message. It compiles and runs fine on my local machine. Also, the changes I made shouldn't cause this error. [INFO] --- maven-compiler-plugin:3.3:testCompile (default-testCompile) @ dolphinscheduler-dao --- |
|
4 participants
Was this PR generated or assisted by AI?
YES, First, use AI to identify redundant code, then manually verify and simplify it.
Purpose of the pull request
part of #18151
Brief change log
Simplify the code with lombok annotations
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md