[Chore][Master] Quietly exit WorkerGroupDispatcher loop on interrupt#18240
Merged
ruanwenjun merged 3 commits intoMay 10, 2026
Merged
Conversation
WorkerGroupDispatcher#run consumed TaskDispatchableEventBus#take() which was annotated with @SneakyThrows, so an InterruptedException raised when the master shuts down (the dispatch thread is parked on the queue) was rethrown as a RuntimeException and surfaced with a full stack trace — alarming "thread died" noise during a perfectly graceful shutdown. Drop @SneakyThrows from take() so it declares InterruptedException, and let the dispatch loop catch it: re-set the interrupt flag, log a single info line, and return so the daemon thread exits cleanly. Also clamp the dispatch-retry waiting time to >= 1s so a freshly-counted failure does not immediately re-enqueue the task against the same unhealthy worker group. In addition, document how to run dolphinscheduler-master tests in the module's CLAUDE.md: no Docker required, watch out for stale JaCoCo classes, surefire forks 4 JVMs in parallel, and the trailing "kill self fork JVM ... 30 seconds after System.exit(0)" line is a harmless warning.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was this PR generated or assisted by AI?
YES, ops 4.7
Purpose of the pull request
Brief change log
WorkerGroupDispatcher#run consumed TaskDispatchableEventBus#take() which was annotated with @SneakyThrows, so an InterruptedException raised when the master shuts down (the dispatch thread is parked on the queue) was rethrown as a RuntimeException and surfaced with a full stack trace — alarming "thread died" noise during a perfectly graceful shutdown.
Drop @SneakyThrows from take() so it declares InterruptedException, and let the dispatch loop catch it: re-set the interrupt flag, log a single info line, and return so the daemon thread exits cleanly.
Also clamp the dispatch-retry waiting time to >= 1s so a freshly-counted failure does not immediately re-enqueue the task against the same unhealthy worker group.
In addition, document how to run dolphinscheduler-master tests in the module's CLAUDE.md: no Docker required, watch out for stale JaCoCo classes, surefire forks 4 JVMs in parallel, and the trailing "kill self fork JVM ... 30 seconds after System.exit(0)" line is a harmless warning.
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md