Skip to content

[Chore][Docs] Refresh commit message convention to match current practice#18242

Merged
ruanwenjun merged 4 commits into
apache:devfrom
ruanwenjun:dev_wenjun_optimizeClaudemd
May 11, 2026
Merged

[Chore][Docs] Refresh commit message convention to match current practice#18242
ruanwenjun merged 4 commits into
apache:devfrom
ruanwenjun:dev_wenjun_optimizeClaudemd

Conversation

@ruanwenjun
Copy link
Copy Markdown
Member

Was this PR generated or assisted by AI?

YES — drafted with Claude Code assistance; reviewed and verified by the author.

Purpose of the pull request

The current docs/docs/{en,zh}/contribute/join/commit-message.md is out of sync with how commits are actually written on dev. The documented format is [DS-ISSUE number][type] subject with lowercase types (feat/fix/docs/style/refactor/test/chore), but recent history uses [Type-ISSUE_ID][Scope] Subject with capitalized types (Improvement/Fix/Chore/Doc/DSIP/Feature). This PR refreshes the doc to match practice and tightens the rules so contributors can produce consistent, concise messages.

Brief change log

  • Rewrite docs/docs/en/contribute/join/commit-message.md and the matching zh version:
    • Format: [Type-ISSUE_ID][Scope] Subject (header) + optional body (bulleted change list) + optional footer.
    • Type list aligned with last 6 months of dev history: Feature / Improvement / Fix / Doc / DSIP / Chore.
    • Issue ID is required for every type except Chore. Subject targets ≤72 chars (soft).
    • Detailed rationale / design / test plan should live in the PR description (PULL_REQUEST_TEMPLATE.md), not the commit body.
    • Added good/bad examples drawn from real dev commits.
  • Update root CLAUDE.md commit-style line: fix the example format (no space between ] and [) and link to the full doc.
  • Add CLAUDE.local.md to .gitignore so contributors using Claude Code can keep personal overrides without polluting git status.

Verify this pull request

This pull request is documentation only — no test coverage required.

@ruanwenjun ruanwenjun requested a review from SbloodyS as a code owner May 9, 2026 23:08
@ruanwenjun ruanwenjun self-assigned this May 9, 2026
@ruanwenjun ruanwenjun added this to the 3.4.2 milestone May 9, 2026
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_optimizeClaudemd branch from 36317b5 to 0ac4749 Compare May 10, 2026 05:32
Copy link
Copy Markdown
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_optimizeClaudemd branch 2 times, most recently from d210e6b to 49f8b94 Compare May 10, 2026 13:08
…tice

- Rewrite en/zh commit-message.md: actual type list (Feature/Improvement/Fix/Doc/DSIP/Chore), format [Type-ISSUE_ID][Scope] Subject, Issue ID required for all types except Chore
- Update root CLAUDE.md commit-style line and link to the full doc
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_optimizeClaudemd branch from 49f8b94 to 9efa61b Compare May 10, 2026 14:18
@sonarqubecloud
Copy link
Copy Markdown

@ruanwenjun ruanwenjun merged commit ac9741b into apache:dev May 11, 2026
122 of 123 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_optimizeClaudemd branch May 11, 2026 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants